Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: openid4vci holder jwt_vc_json-ld missing context #2047

Merged
merged 5 commits into from
Oct 11, 2024
Merged

fix: openid4vci holder jwt_vc_json-ld missing context #2047

merged 5 commits into from
Oct 11, 2024

Conversation

Sshovon
Copy link
Contributor

@Sshovon Sshovon commented Oct 1, 2024

This PR fixes openid4vci holder module jwt_vc_json-ld and ldp_vc missing context issue during credential build. I have described the whole issue here.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b5ab211

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

TimoGlastra
TimoGlastra reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙌

@TimoGlastra
Copy link
Contributor

Can you sign-off your commit? I can't merge it otherwise

https://github.com/openwallet-foundation/credo-ts/pull/2047/checks?check_run_id=31280956610

@Sshovon Sshovon force-pushed the fix/oid4vciholder-jsonld-credential branch from 188a048 to e0071c1 Compare October 9, 2024 09:06
@Sshovon
Copy link
Contributor Author

Sshovon commented Oct 9, 2024

Hey @TimoGlastra, I have added the sign-off. Thanks.

@TimoGlastra
Copy link
Contributor

Can you address the ci issues (linting)? Otherwise this is good to go!

@Sshovon
Copy link
Contributor Author

Sshovon commented Oct 10, 2024

Hey @TimoGlastra , I have added the linting fix.

@TimoGlastra TimoGlastra merged commit 8037495 into openwallet-foundation:main Oct 11, 2024
14 checks passed
@TimoGlastra
Copy link
Contributor

Thanks a lot!!

auer-martin pushed a commit to auer-martin/aries-framework-javascript that referenced this pull request Oct 15, 2024
@Sshovon @auer-martin
fix: openid4vci holder jwt_vc_json-ld missing context (openwallet-fou…
b28753d 
…ndation#2047)

Signed-off-by: frcs <[email protected]>
Signed-off-by: Martin Auer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sshovon @TimoGlastra