Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updating dependabot file to support GHA, TS, JS, dev container and docker packages #1881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: updating dependabot file to support GHA, TS, JS, dev container and docker packages #1881

wants to merge 2 commits into from

Conversation

rajpalc7
Copy link

No description provided.

@rajpalc7
Copy link
Author

Hi @WadeBarnes , this is ready for review now.

WadeBarnes
WadeBarnes approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll leave the final review and approval to the regular maintainers.

genaris
genaris requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajpalc7 ! Could you fix the prettier errors? It can be done by running yarn format.

TimoGlastra
TimoGlastra requested changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure to group all the dependencies into one PR? I'm really overwhelmed by the 100s of dependabot PR notifications I have to deal with on a daily basis and it distracts from more meaningful PRs

Also -- can we configure it to only make patch updates for production dependencies? I'm not really intersted in updates for dev-deps and would rather update these manually once in a while.

Also -- is there a way to fully automate the merging of patches if the CI succeeds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimoGlastra TimoGlastra TimoGlastra requested changes

@genaris genaris genaris requested changes

@WadeBarnes WadeBarnes WadeBarnes approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajpalc7 @genaris @WadeBarnes @TimoGlastra