-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Split AFJ demo for two cases: Main and DidCommV2 #1470
base: feat/didcomm-v2
Are you sure you want to change the base?
feat: Split AFJ demo for two cases: Main and DidCommV2 #1470
Conversation
Signed-off-by: Artemkaaas <[email protected]>
Signed-off-by: Artemkaaas <[email protected]>
Signed-off-by: Artemkaaas <[email protected]>
…d conencted tests. Signed-off-by: Artemkaaas <[email protected]>
Signed-off-by: Artemkaaas <[email protected]>
I think overall LGTM. I'm not sure though on splitting it up. What if we add an option to create a v1 or v2 invitation? And on the other side we just do receive invitation and it will accept both? I think an agent should be able to run both at the same time, so I don't see a specific reason to split it up |
This is how it's currently done in |
Discussed on AFJ WG call. It's okay to split up the demo. |
Started work on splitting the Alice/Faber demo into smaller cases. Using this we can add demos for various optional modules.
Main
- general demo of issuing credentials and presenting the proofDidComm V2
- demo reflecting supported didcomm v2 protocols