Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): add docker image #257

Closed

Conversation

TimoGlastra
Copy link
Contributor

Dependant on #256

Also siwtches the rest package to use indy-vdr and anoncreds packages

Tests are currently passing but 2 suites fail due to a cleanup issue that still needs to be resolved

There are also several TODO items that should be reviewed

Signed-off-by: Matthew Dean <[email protected]>
Signed-off-by: Matthew Dean <[email protected]>
1. refactored module instantiation to a helper function
2. configured correct types to support v1 and v2 credential and proof protocols and correct formats
3. proof controller updated to take parameters like agent
4. re-enabled oob proof api as create-request

Signed-off-by: Matthew Dean <[email protected]>
Signed-off-by: Matthew Dean <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra changed the title chore: add docker image feat(rest): add docker image Mar 27, 2024
Signed-off-by: Timo Glastra <[email protected]>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 64.20912% with 267 lines in your changes are missing coverage. Please review.

Project coverage is 62.15%. Comparing base (e5eeaf0) to head (68b0504).

Files Patch % Lines
...llers/didcomm/credentials/CredentialsController.ts 44.73% 55 Missing and 8 partials ⚠️
...src/controllers/didcomm/proofs/ProofsController.ts 50.00% 49 Missing and 9 partials ⚠️
...rollers/didcomm/out-of-band/OutOfBandController.ts 52.80% 40 Missing and 2 partials ⚠️
...llers/didcomm/connections/ConnectionsController.ts 38.88% 29 Missing and 4 partials ⚠️
...ackages/rest/src/controllers/did/DidsController.ts 72.58% 17 Missing ⚠️
...t/src/controllers/anoncreds/AnonCredsController.ts 79.71% 14 Missing ⚠️
packages/rest/src/authentication.ts 65.38% 9 Missing ⚠️
...ontrollers/didcomm/proofs/ProofsControllerTypes.ts 71.42% 8 Missing ⚠️
packages/rest/src/server.ts 71.42% 5 Missing and 1 partial ⚠️
.../didcomm/basic-messages/BasicMessagesController.ts 81.48% 4 Missing and 1 partial ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #257       +/-   ##
===========================================
- Coverage   86.78%   62.15%   -24.63%     
===========================================
  Files          24       78       +54     
  Lines        1241     1826      +585     
  Branches      270      372      +102     
===========================================
+ Hits         1077     1135       +58     
- Misses        164      635      +471     
- Partials        0       56       +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants