-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OpenID4VP Proof request Base work and UI #1296
base: main
Are you sure you want to change the base?
feat: OpenID4VP Proof request Base work and UI #1296
Conversation
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Youssef <[email protected]>
Signed-off-by: Mostafa Youssef <[email protected]>
Signed-off-by: Mostafa Youssef <[email protected]>
Signed-off-by: Mostafa Youssef <[email protected]>
Signed-off-by: Mostafa Youssef <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
Signed-off-by: Mostafa Gamal <[email protected]>
@@ -197,14 +199,14 @@ | |||
"react-native-fs": "^2.16.6", | |||
"react-native-gesture-handler": "^1.10.3", | |||
"react-native-get-random-values": "^1.7.0", | |||
"react-native-gifted-chat": "*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can understand that *
is super generic, but any particular reason for setting to a very specific peer dependencies? Usually keep compatibility at major level (starting with ^
) is fine. Similar comment for react-native-qrcode-svg
, and react-native-reanimated
changes below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "*" caused installing latest stable version, and it caused a whole lot of conflicts with other packages that are mot updated, and to do that in this PR is a big mess. I had to fix the version to get things aligned together and get the app to build and tests to succeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, I believe leaving yarn to pickup latest updated versions for any packages is recipe for bugs. We have to dedicate PRs to solely update specific packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can be specific at dependencies
but more liberal with peer dependencies
. Also, dependencies should not be updated as a side-effect, it should be explicit and managed by the lock file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep in mind that yarn install
MAY produce unexpected dependency change. yarn install --immutable
is the safest command to use and void unexpected changes to the lock file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never meant to touch any of that :). It NEVER succeeded until I fixed versions for those packages. Let me know if you have another idea and we can hop on a call and discuss
1b04783
to
3c80171
Compare
Quality Gate passedIssues Measures |
Summary of Changes
This PR introducing the flow of accepting a proof request from an issuer using OIDC flow
Related Issues
Please reference here any issue #'s that are relevant to this PR, or simply enter "N/A" if this PR does not relate to any existing issues.
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.