Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #176

Conversation

berendsliedrecht
Copy link
Contributor

depends on #170

Updated lerna to newer version to remove dependabot security issues.

andrewwhitehead
andrewwhitehead previously approved these changes Sep 5, 2023
TimoGlastra
TimoGlastra previously approved these changes Sep 6, 2023
@berendsliedrecht berendsliedrecht dismissed stale reviews from TimoGlastra and andrewwhitehead September 7, 2023 11:36

The merge-base changed after approval.

@andrewwhitehead
Copy link
Contributor

Looks like it's having trouble resolving the ref-napi module?

@genaris
Copy link
Contributor

genaris commented Sep 7, 2023

Looks like it's having trouble resolving the ref-napi module?

I think it needs to be updated with base branch to get the latest changes from #170.

TimoGlastra
TimoGlastra previously approved these changes Sep 8, 2023
@@ -1288,6 +1143,7 @@
"@types/ref-struct-di" "*"

"@types/2060.io__ref-napi@npm:@types/ref-napi", "@types/ref-napi@*":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI still failing 😭. It looks like it will also need to clean yarn lock file + yarn install for it to properly fetch the new types dependencies.

@@ -1456,7 +1290,15 @@
dependencies:
"@types/ref-napi" "*"

"@types/ref-struct-di@*", "@types/ref-struct-di@^1.1.6":
"@types/ref-napi@*":
name "@types/2060.io__ref-napi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this replacement came from the previous types config that might be cached somewhere (@types/2060.io__ref-napi does not actually exist). I could solve this locally by deleting it from yarn.lock (or removing the yarn lock file entirely) and running yarn install again. That way it will retrieve the actual @types/ref-napi package as it should be in the first place.

Signed-off-by: Berend Sliedrecht <[email protected]>
@andrewwhitehead andrewwhitehead merged commit cd4fd85 into openwallet-foundation:main Sep 11, 2023
25 of 26 checks passed
jamshale pushed a commit to jamshale/aries-askar that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants