Adjust permissions to support uniffi module outside the repo #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: conanoc <[email protected]>
src/lib.rs
Outdated
|
|
||
| pub mod kms; | ||
|
|
||
| mod store; | ||
| pub mod store; |
There was a problem hiding this comment.
What's in the store module that's not being exposed?
There was a problem hiding this comment.
This is the symbols I use from store.
pub use aries_askar::store::{entry, PassKey, Session, Store, StoreKeyMethod};
There was a problem hiding this comment.
Can't you just use aries_askar::{entry, PassKey, Session, Store, StoreKeyMethod} though?
Signed-off-by: conanoc <[email protected]>
src/kms/entry.rs
Outdated
| @@ -65,6 +65,11 @@ impl KeyEntry { | |||
| self.name.as_str() | |||
| } | |||
|
|
|||
| /// Accessor for the key tags | |||
| pub fn tags_as_ref(&self) -> &Vec<EntryTag> { | |||
There was a problem hiding this comment.
This could return a slice to avoid exposing implementation details: self.tags.as_slice()
Signed-off-by: conanoc <[email protected]>
Signed-off-by: conanoc <[email protected]>
|
After all, What I need is just adding an accessor for |
andrewwhitehead
approved these changes
Sep 8, 2023
jamshale
pushed a commit
to jamshale/aries-askar
that referenced
this pull request
Aug 18, 2024
…let-foundation#175) * Adjust permissions to support uniffi module outside the repo Signed-off-by: conanoc <[email protected]> * respond to comments Signed-off-by: conanoc <[email protected]> * hide store, return tags as slice Signed-off-by: conanoc <[email protected]> * revert unnecessary changes Signed-off-by: conanoc <[email protected]> --------- Signed-off-by: conanoc <[email protected]> Co-authored-by: Andrew Whitehead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look @andrewwhitehead
I could make a uniffi module as a separate crate with these changes. I added some dummy documents in error.rs and store.rs to make them public.