Add profile management and store export to JS wrapper #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice timing. #170 introduces an example application to be used for testing. It is still not an easy process to test the functionality though. |
andrewwhitehead
force-pushed
the
js/upd
branch
from
934509b
to
9d081f1
Compare
berendsliedrecht
previously approved these changes
Sep 5, 2023
| State *state = new State(&cb); | ||
| state->rt = &rt; | ||
|
|
||
| ErrorCode code = askar_store_copy( |
There was a problem hiding this comment.
This function does not seem to use the storeHandle.
TimoGlastra
previously approved these changes
Sep 6, 2023
andrewwhitehead
dismissed stale reviews from TimoGlastra and berendsliedrecht
via
da27a79
andrewwhitehead
force-pushed
the
js/upd
branch
from
19452cf
to
da27a79
Compare
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
andrewwhitehead
force-pushed
the
js/upd
branch
from
da27a79
to
24afabe
Compare
andrewwhitehead
merged commit b9f004c
into
openwallet-foundation:main
25 of 26 checks passed
jamshale
pushed a commit
to jamshale/aries-askar
that referenced
this pull request
Aug 18, 2024
Add profile management and store export to JS wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in draft because I can't build or test the react-native updates.
Also adds a missing store export test for the Python wrapper.