Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to go1.23 #245

Merged
merged 1 commit into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-build-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v2.2.0
with:
go-version: '1.22'
go-version: '1.23'
check-latest: true
cache: true

Expand All @@ -35,7 +35,7 @@ jobs:

- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v2.2.0
with:
go-version: '1.22'
go-version: '1.23'
check-latest: true
cache: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v3.3.0
with:
go-version: '1.22'
go-version: '1.23'
check-latest: true

- name: Install cosign
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/snapshot.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: '1.22'
go-version: '1.23'
check-latest: true

- name: Install GoReleaser
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/verify.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v3
with:
go-version: '1.22'
go-version: '1.23'
check-latest: true
cache: true
- name: golangci-lint
uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
with:
version: v1.59
version: v1.60
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/openvex/vexctl

go 1.22.5
go 1.23.1

require (
github.com/google/go-containerregistry v0.20.2
Expand Down
2 changes: 1 addition & 1 deletion pkg/ctl/implementation.go
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ func (impl *defaultVexCtlImplementation) NormalizeProducts(subjects []productRef
case strings.HasPrefix(pref.Name, "pkg:"):
// When there are other purls, we only attest them as subjects if
// the product reference has hashes
if pref.Hashes != nil && len(pref.Hashes) > 0 {
if pref.Hashes != nil && len(pref.Hashes) > 0 { //nolint: gosimple
otherRefs = append(otherRefs, pref)
} else {
unattestableRefs = append(unattestableRefs, pref)
Expand Down