-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(location-field): make location group order configurable #771
Open
amy-corson-ibigroup
wants to merge
21
commits into
opentripplanner:master
Choose a base branch
from
ibi-group:reorder-other-to-first
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7aed84c
feat(location-field): make location group order configurable
amy-corson-ibigroup 4781771
Add "renderOtherFirst" story
amy-corson-ibigroup f1e412b
Finish OtherFeaturesHeader text description
amy-corson-ibigroup 992d76a
update snapshots
amy-corson-ibigroup 0c62fb1
fix(map-popup): fix type error in stories
amy-corson-ibigroup 6380c4c
update internal deps
amy-corson-ibigroup 8b1259f
Merge branch 'master' into reorder-other-to-first
amy-corson-ibigroup 6c0293a
Merge branch 'master' into reorder-other-to-first
amy-corson-ibigroup 8ee7f11
update yarn.lock
amy-corson-ibigroup b83918d
Merge branch 'reorder-other-to-first' of https://github.com/ibi-group…
amy-corson-ibigroup 6443942
Merge branch 'master' into reorder-other-to-first
amy-corson-ibigroup d19c297
Update yarn.lock
amy-corson-ibigroup 048c899
Add a11yOverrideParams
amy-corson-ibigroup 03c02ac
Change configuration from boolean to other first, instead to array of…
amy-corson-ibigroup 5f30a19
Cleanup
amy-corson-ibigroup 39cc6e7
change key to title
amy-corson-ibigroup e2b352e
Add GeocoderResultsConstants and clean up results headers
amy-corson-ibigroup 2e7b01b
refactor: better incooperate GeocoderResultsConstants
amy-corson-ibigroup fd64616
clean up comments and capitalization
amy-corson-ibigroup fa7dadb
only render features if there are features
amy-corson-ibigroup 1508e95
update snapshots
amy-corson-ibigroup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make Storybook create the controls using
argTypes
instead? (Storybook will add that to its "Controls" tab - I should have mentioned that in my previous review but somehow thought you knew) Do that for this story only. Refer to e.g.otp-ui/packages/route-viewer-overlay/src/RouteViewerOverlay.story.tsx
Line 102 in f75dd89