Support naming and keying transit vehicle overlay #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-heppner-ibigroup
approved these changes
Nov 4, 2024
| @@ -341,7 +345,13 @@ class DefaultMap extends Component { | |||
| {/* The default overlays */} | |||
| <EndpointsOverlay /> | |||
| <RouteViewerOverlay /> | |||
| <TransitVehicleOverlay ModeIcon={ModeIcon} /> | |||
| <TransitVehicleOverlay | |||
| id={routeBasedTransitVehicleOverlayNameOverride || undefined} | |||
There was a problem hiding this comment.
maybe move the || undefined into the const so you don't have to repeat it on each of these!
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously there was no way to name/key the transit vehicle overlay. This adds a new way to do that without needing any new explicit configuration types!