Change build image to debian:oldoldstable to lower GLIBC requierment #14
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,30 +10,36 @@ on: | |
| jobs: | ||
| build: | ||
| env: | ||
| NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }} | ||
| runs-on: ubuntu-latest | ||
| container: debian:oldoldstable | ||
| strategy: | ||
| fail-fast: true | ||
|
|
||
| steps: | ||
| - name: Install X11 dependencies | ||
| run: | | ||
| apt-get update | ||
| apt-get install -y xorg-dev libwayland-dev libxkbcommon-dev wayland-protocols extra-cmake-modules | ||
| - name: Install build dependencies | ||
| run: | | ||
| apt-get install -y curl wget git cmake | ||
| VERSION_ID=$(awk -F= '/^VERSION_ID=/{gsub(/"/, "", $2); print $2}' /etc/os-release) | ||
| wget -q https://packages.microsoft.com/config/debian/$VERSION_ID/packages-microsoft-prod.deb | ||
| dpkg -i packages-microsoft-prod.deb | ||
| apt-get update | ||
| apt-get install -y powershell | ||
|
There was a problem hiding this comment. Why is it suddenly necessary to install powershell manually? Does it not come with the container? There was a problem hiding this comment. GitHub actions are a bit weird, basically GitHub installs all one could need into the ubuntu image they provide when using a container it runs that container next to the ubuntu image and then the commands inside the container which is just the bare bones debian docker container from https://hub.docker.com/_/debian (~50MB compressed) https://docs.github.com/en/actions/using-jobs/running-jobs-in-a-container |
||
| - uses: actions/checkout@v3 | ||
| - name: Setup .NET Core | ||
| uses: actions/setup-dotnet@v3 | ||
| with: | ||
| dotnet-version: 6.0.x | ||
| - name: Download dependencies and create Nuget Package | ||
| run: ./make_nuget.ps1 "" ${{ github.run_number }} | ||
| shell: pwsh | ||
| - uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: NugetPackage | ||
| path: ./artifacts/*.nupkg | ||
| - name: Deploy Nuget Package | ||
| run: dotnet nuget push ./artifacts/*.nupkg -k $NUGET_API_KEY -s https://api.nuget.org/v3/index.json | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it not be more stable to just fix the version in place so that we manually control which debian/ubuntu version we are compiling against?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can do that too, my general idea was that debian:oldoldstable is the oldest still supported version many other distos depend upon, so that way we stay on a version that is still generally used by some linux distos while not yet being too old.
Further this kinda auto updates which has pros and cons since well it auto updates so it stays updated / patched but also may break when a new version gets released and some one did not directly update their system and the newer glibc is not working anymore since OpenTK requires the newer one already