Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the last merge conflict #972

Closed
wants to merge 48 commits into from

Conversation

sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Nov 13, 2024

The Ballad of Unified Branches

devnet-ready and devnet clashed,
testnet’s trials and main’s steadfast.
A pull request, both bold and true,
Resolved their rift, their strength renewed.

No diff remains, no merge astray,
Peace crowned their code this final day.
devnet-ready, devnet, testnet, main—
Together now, in Git’s domain.

gztensor and others added 30 commits October 16, 2024 16:22
Fix: Hotkey swap causes parent key to lose emissions from children
…ainnet

Fix/merge conflicts testnet mainnet
* skip netuid 0 for pending emission accum

* comment
* add comment also

* chore: fmt

* add back delta handling in helpers

* track removals in stake delta

* handle stake delta in ck swap func

* add tests back

* add tests for staking back

* add back test for ck swap
* respect chk for set weights min stake filter

* use for test func

* respect chk in set weights call also

* add tests back

* fix weights min stake tests also
* skip netuid 0 for pending emission accum

* comment
* add comment also

* chore: fmt

* add back delta handling in helpers

* track removals in stake delta

* handle stake delta in ck swap func

* add tests back

* add tests for staking back

* add back test for ck swap
* respect chk for set weights min stake filter

* use for test func

* respect chk in set weights call also

* add tests back

* fix weights min stake tests also
@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Nov 13, 2024
Copy link

🚨🚨🚨 HOTFIX DETECTED 🚨🚨🚨

It looks like you are trying to merge a hotfix PR into . If this isn't what you wanted to do, and you just wanted to make a regular PR, please close this PR, base your changes off the branch and open a new PR into .

If you are trying to merge a hotfix PR, please complete the following essential steps:

  1. go ahead and get this PR into merged, so we can get the change in as quickly as possible!
  2. merge into , bumping
  3. deploy
  4. merge into , bumping
  5. deploy
  6. merge into

If you do not complete these steps, your hotfix may be inadvertently removed in the future when branches are promoted to main, so it is essential that you do so.

@sam0x17 sam0x17 changed the base branch from main to devnet-ready November 13, 2024 15:31
@sam0x17 sam0x17 closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants