-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fuzzing to matrix functions #439
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -206,6 +206,7 @@ pub fn sigmoid_safe(input: I32F32, rho: I32F32, kappa: I32F32) -> I32F32 { | |||
|
|||
// Returns a bool vector where an item is true if the vector item is in topk values. | |||
#[allow(dead_code, clippy::indexing_slicing)] | |||
#[test_fuzz::test_fuzz] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add bounds to these? My fear is that the fuzzer would run iterations on values outside what is realistic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that's probably a feature rather than a bug unless it causes a false positive someday
…into arbitrage_coldkeys
prevent accidental changes to storage structs
always run e2e tests on all pull requests and on push for major branches
…rehensive_coldkey_swap_scenarios
…rehensive_coldkey_swap_scenarios
Schedule Coldkey Swap
chore: remove coldkey swap rpc
Fixes #421.