Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzing to matrix functions #439

Closed
wants to merge 358 commits into from
Closed

Add fuzzing to matrix functions #439

wants to merge 358 commits into from

Conversation

keithtensor
Copy link
Contributor

Fixes #421.

@keithtensor keithtensor requested a review from a team May 20, 2024 15:38
@keithtensor keithtensor marked this pull request as draft May 20, 2024 15:39
Copy link
Contributor

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -206,6 +206,7 @@ pub fn sigmoid_safe(input: I32F32, rho: I32F32, kappa: I32F32) -> I32F32 {

// Returns a bool vector where an item is true if the vector item is in topk values.
#[allow(dead_code, clippy::indexing_slicing)]
#[test_fuzz::test_fuzz]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add bounds to these? My fear is that the fuzzer would run iterations on values outside what is realistic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that's probably a feature rather than a bug unless it causes a false positive someday

Samuel Dare and others added 28 commits July 8, 2024 21:09
prevent accidental changes to storage structs
always run e2e tests on all pull requests and on push for major branches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fuzzing
10 participants