Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ostraca #195

Closed
wants to merge 8 commits into from
Closed

Ostraca #195

wants to merge 8 commits into from

Conversation

unconst
Copy link
Contributor

@unconst unconst commented Nov 10, 2023

No description provided.


Ok(())
}

#[pallet::call_index(69)]
#[pallet::weight((Weight::from_ref_time(14_000_000)
Copy link
Contributor

@Rubberbandits Rubberbandits Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be benchmarked, as it seems the ostraca function is going to be pretty read/write heavy as it iterates through all stakers for a hotkey.

@welikethestock welikethestock deleted the ostraca branch November 29, 2023 00:18
@Rubberbandits Rubberbandits restored the ostraca branch November 29, 2023 00:20
@Rubberbandits Rubberbandits reopened this Nov 29, 2023
Copy link
Contributor

@Rubberbandits Rubberbandits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding dynamic weight to ostraca function, and fixing unit testing, LGTM

Copy link
Contributor

@welikethestock welikethestock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@unconst unconst closed this Mar 27, 2024
@unconst unconst deleted the ostraca branch March 27, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants