-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ostraca #195
Conversation
|
||
Ok(()) | ||
} | ||
|
||
#[pallet::call_index(69)] | ||
#[pallet::weight((Weight::from_ref_time(14_000_000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will need to be benchmarked, as it seems the ostraca function is going to be pretty read/write heavy as it iterates through all stakers for a hotkey.
…NotRegistered error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding dynamic weight to ostraca function, and fixing unit testing, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
No description provided.