-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity system for Subnets and Root-validators #191
Conversation
…ow identities for root validators and subnet owners
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Question: is the max data length for create_identity_info
32bytes?
let data = Data::Raw(vec![0; 32].try_into().unwrap());
I see that pgp_fingerprint
is required to have 20bytes, are there other requirements for the rest of the fields? Want to make a note of any requirements on the bittensor API side.
Small nit: Assuming these tests just need to be updated? error[E0432]: unresolved import `crate::mock`
--> pallets/registry/src/tests.rs:1:13
|
1 | use crate::{mock::*, Error, Event};
| ^^^^ could not find `mock` in the crate root
error[E0616]: field `id` of struct `UntrackedSymbol` is private
--> pallets/registry/src/types.rs:369:44
|
369 | let type_info = registry.resolve(type_id.id).unwrap();
| ^^ private field
|
help: a method `id` also exists, call it with parentheses
|
369 | let type_info = registry.resolve(type_id.id()).unwrap();
| ++
error[E0616]: field `type_def` of struct `Type` is private
--> pallets/registry/src/types.rs:380:62
|
380 | if let scale_info::TypeDef::Variant(variant) = &type_info.type_def {
| ^^^^^^^^ private field
|
help: a method `type_def` also exists, call it with parentheses
|
380 | if let scale_info::TypeDef::Variant(variant) = &type_info.type_def() {
| ++
error[E0616]: field `variants` of struct `TypeDefVariant` is private
--> pallets/registry/src/types.rs:382:7
|
382 | .variants
| ^^^^^^^^ private field
|
help: a method `variants` also exists, call it with parentheses
|
382 | .variants()
| ++
error[E0616]: field `len` of struct `TypeDefArray` is private
--> pallets/registry/src/types.rs:393:12
|
393 | ... arr.len
| ^^^ private field
|
help: a method `len` also exists, call it with parentheses
|
393 | arr.len()
| ++ |
The way the arguments work for the different fields are like so: You have a struct of different fields, website, email, etc and each of them can be the type of |
This PR implements
pallet-registry
, a new system which allows validators and subnet creators to commit information about themselves to the chain itself. This will replace the delegates.json list by enforcing all data on-chain.