Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return error message instead of raising exception #2244

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

gus-opentensor
Copy link
Collaborator

Overview

  • Previously we would raise an exception and stdout the whole stack trace, this update makes enables a terse error messages.

Ex:

image

@gus-opentensor gus-opentensor changed the title feat: return error message instead raising exception feat: return error message instead of raising exception Aug 16, 2024
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the instances here where we also unlock the hotkey, do we want to include those in the try block?

@ibraheem-opentensor
Copy link
Contributor

In the instances here where we also unlock the hotkey, do we want to include those in the try block?

Interesting thought - but confirming if we actually unlock the hotkey currently. afaik, hotkey is without password in our current setup

Copy link
Contributor

@ibraheem-opentensor ibraheem-opentensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think we dont password protect our hotkeys but we can confirm that

@gus-opentensor gus-opentensor merged commit 6dbc1f1 into staging Aug 17, 2024
34 of 36 checks passed
@thewhaleking thewhaleking deleted the feat/gus/update-err-msg-pw branch August 17, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants