[Revolution] add associated ip info #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on subtensor PR opentensor/subtensor#179 and subtensor endpoint node upgrades |
eduardogr
added a commit
that referenced
this pull request
Oct 2, 2023
* fix import of errors * dont test set weights (gone) * fix register test * fix return values for staking ext * unneeded thread pool test * fix metagraph test, pass sub * fix prometheus test * fix sub integration tests * fix dendrite tests * no prometheus * relax requirements * relax requirements * use correct mock sub * fix docker file * bump version * add a synchronous forward function to the dendrite * allow synchronous calling the dendrite allow async axon functions and also the forward * fix synapse to_headers to not pass through optionals regardless of python version * allow list of grads * fix patching reregister test * move tests * rename metagraph tests * patch create _pow instead * specify kwargs * mock torch cuda available * patch temp only * remove net import * allow larger sizes of tensors; ensure that required tensors are never added to headers * add tests for tensor pass through * fix typehint * patch better * unneccessary var * patch better * fix patch * bt.tensor changes * move to python for btcli * fix patching in register tests * move patch to decorator on test func * fix __ss58_format__ failing * fix double serving * add serve to axon * adds dict tensor to serialization format * fixes torch type issues (#1455) fixes tensor issues * dict tensors * add tests for tensor types * add tensor type tests * add dendrite side timeouts * remove headers print on dendrite side * add another synapse copy * update revolution to current master 5.3.1 * (WIP) add config and wallet back * remove flaky patch dendrite tests * fix netid check, add unwrap for list type * fix config and return __is_set to it's proper place * pre merge * extract wallet and keyfile tests * fix tests * fix tests for python3.11 * fix integration test connection * fix test patching based on python version * add connection errors to dendrite * add dendrite unreachable errors * fix list response dendrite * delete unused ipython * fix python3.8 issue with | operator * add proper defaults to config parsing * remove config and wallet * fix axon defaults error * quick fix for validator quantile default value * add ansible_vault * stop * Remove circleCI call to non-existent build_protos.sh * run black format * Merge main into revolution (#1469) * (un)Staking multiple avoid tx limit (#1244) * add tx rate limit * wait for tx limit if not done multi stake/unstake * dont "decrypt" hotkey * Grab delegates details from GitHub (#1245) * add url to init * add dataclass and util functions * use in cli * remove delegates json --------- Co-authored-by: joeylegere <[email protected]> * Fix list_delegates on non-archive nodes (#1232) * Change how pull of archival data is handled * fix for list_delegates too * . * use empty dict * fix spacing * specify exception * log out * add space in log message * use warning instead * Improve development workflow documentation * Update DEVELOPMENT_WORKFLOW.md * (un)Staking multiple avoid tx limit (#1244) * add tx rate limit * wait for tx limit if not done multi stake/unstake * dont "decrypt" hotkey * Grab delegates details from GitHub (#1245) * add url to init * add dataclass and util functions * use in cli * remove delegates json --------- Co-authored-by: joeylegere <[email protected]> * Fix list_delegates on non-archive nodes (#1232) * Change how pull of archival data is handled * fix for list_delegates too * . * use empty dict * fix spacing * specify exception * log out * add space in log message * use warning instead * Improve development workflow documentation * Update DEVELOPMENT_WORKFLOW.md * progress on fix mock subtensor rename test files for discovery catch nonce errors skip long tests test durations group cli tests to same runner try group again try to group tests using arg patch start server dont use groups and wait longer to teardown dont kill loadgroup . update durations update durations delay reruns progress on new mock more progress add back mock init create axons and prometheus fix imports add reset state fix mock calls fix setup move some extr send to subtensor impl move stake ext call move unstake ext add extr outline to mock sub add ext bodies fix type ann return empty map on None fix global state * [BIT-351] Ask for wallet name on btcli unstake (#1387) add not * fix query map mock * inc subnetN on mock reg * add active to neuron on mock reg * dont store balance in chainstate * use dict comprehension * don't print __is_set when displaying config * use axon info from axon module * set is set for Config in tests * passes overview * remove neurons, take out multiforward Synapse * take out _neuron, these are in openminers & openvalidators now * cleanup dendrite multi_forward * missed MultiForward class in dendrite * fix tests * dont skip * return data free of balance * return proper types * no nonces * use same format for balances * allow block for is delegate * fix nominate * fix nominate again :) * fix typehint and return value==None * fix total stake tracking * nominate passes * fix state for ismember and totalstake * not returning last part of tuple * oops, dont pass self twice * return null neuron * get mock block hash * add set diff mock * fix total issuance and balance * add rate limit storage * fix loop over nom * fix some unit tests * fix pow test * fix get delegates mock * fix typo * typo again * remove assert on err * typo on storage * spacing * BlocksSinceLastStep instead * fix list subnets * dont skip * add is set map * fix patch * setup mock net 3 * add a do_prometheus serve func * add to mock * remove unused examples * update bittensor version into to current (510) * fix prometheus test * fix some staking tests * fix transfer tests * add do_set_weights * add do_set_weights to mock * use dsw in tests * use == true * use == True * add do_serve_axon * use typeddict * add do serve axon mock * add _ to subtensor.do_* methods * add _subtensor.types * fix circular import * fix mock get_balances * return uid in mock * run setup for tests with mock sub * use mock sub for tests * all subtensor tests pass * fix mock with underscore * nominators mock should be list tuple not dict * fix duplicate setup * Update README.md fix typo * Fix integration test * remove multiforward from synapse (missed before) * remove hotkey from proto and dendrite * Weight Utils fix (#1372) When Torch sets zeros or ones, it does this on the CPU. The metagraph is loaded on GPU. This results in errors—proposed fix. * Extract config to new package (#1401) * integrate openconfig progess * add type or suppress for argparse * use for problematic types * fix type hints * move test under testcase class * move tests under testcase class * add test for btcli with empty arguments on every command * remove unneeded setup from test * remove type or suppress from int * remove to defaults test * use dot get for prefix check * move tests to config repo * fix test by passing argv=[] * use new package name * fix name of openconfig package * Extract wallet (#1403) * integrate openconfig progess * add type or suppress for argparse * use for problematic types * fix type hints * move test under testcase class * move tests under testcase class * add test for btcli with empty arguments on every command * remove unneeded setup from test * remove type or suppress from int * remove to defaults test * use dot get for prefix check * move test to package * move wallet mock * move some utils to package * move wallet to package * move reregister to registration utils * add mocks * move keyfile to package * move test to utils tests * use different naming * fix import * change function name and use kwargs * modify naming * add is_hotkey_registered * use new function * fix patch * arg is cuda (typo) * specify reregister true * use generate wallet * get mock wallet during tests * extract get ss58 format util * remove _mock arg * extract tests * import from base * use subtensor for get_balance * use new hotkey during test * fix mocking * add new packages to reqs file * use new package naming * bump wallet dep * BTCli integration with new governance protocol (#1398) * Begin senate cli * Add helper functions to subtensor object for query_module, query_module_map * Remove unused senate helpers * Rename SenateCommand -> ProposalsCommand * Remove unused proposals info datatype * Add proposals data in rich table * Clarify + beautify calldata column * Add SenateRegisterCommand * Add helper function wallet.is_senate_member * Add subtensor *_senate extrinsics, is_senate_member, get_vote_data impl * Use helper function to check senate membership * Add command to view senate members * Use get_vote_data helper and refactor call data formatting for recursion * Add senate_vote and senate_leave cmd classes * Add membership check in senate_register command * Add senate_leave, senate_vote extrinsic functions * Import senate_leave, senate_vote extrinsic functions in subtensor_impl * Add senate, proposal_votes, senate_leave, senate_vote cmds to cli * Move closure helper funcs to main scope, add display_votes helper * Add senate size and active proposals metric, vote overview and nice names * Add delegate nice-name support to proposal_votes * Use coldkey for senate actions instead of hotkey * Reverting unnecessary commits for next release. (#1415) * Reverting unnecessary commits for next release. * fix missed conflict --------- Co-authored-by: ifrit98 <[email protected]> * fix merge conflict * fix dockerignore * Use delegate nice-names in senate view * use new regex for test * make test assertion more verbose * add to config for test * bump version * create api calls for senate info * add block optional to is senate member * prefer using subtensor api * use new api calls * dont sync metagraph on neuron init * remove multiforwad * fix error calling metagraph from subtensor without passing (#1426) * fix error calling metagraph from subtensor without passing * Update bittensor/_subtensor/subtensor_impl.py Co-authored-by: Cameron Fairchild <[email protected]> --------- Co-authored-by: Cameron Fairchild <[email protected]> * Fix docker and pypi upload commands (#1375) Co-authored-by: philanthrope <[email protected]> * Fix cli ask for wallet hotkey name (#1430) * check if NOT hotkey set * add test for stake and unstake * remove unneeded import * add tests for delegate and undelegate * add tests for delegate ss58 arg * always sync metagraph during subtensor.metagraph * derp * remove unused HelpCommand class for miners/validators * update changelog from running add_notes_changelog.sh * fix script for the changelog * add changelog * Update scripts/release/github_utils.sh * add weights call to subtensor (#1436) * add weights call to subtensor * add bonds call * use bonds and weights calls for sync * move into neurons * fix type hints * move func to chain data * use new funcs in meta init * fix kwarg name * Revert "use new funcs in meta init" This reverts commit 955e671. * update dockerignore file (#1428) * update dockerignore file * add newline * fix function name in script * add new changelog additions * update changelog again * make minor release * remove wallet impl * use reregister from utils * add arg for base miner reregister * fix mock return values * fix return format to use Tuple * raise -> return * Revert "fix return format to use Tuple" This reverts commit 0252fcc. * Revert "fix mock return values" This reverts commit 2df31eb. * raise correct errors in mock * return tuples for do server * move mocks to bt_wallet package (#1441) * bump bittensor-wallet req, update cryptography security req * Fixes #1442 * adds black formatting to release branch and circleCI check for format * Btlm miner (#1463) * BTLM initial commit * Fixed up the BTLM to run on GPU and on Bittensor network * Added missing trust_remote_code for now as we trust Cerebras --------- Co-authored-by: Ala Shaabana <[email protected]> * Don't finalize set_weights ext (#1461) * pass wait_for_* params to call * format * format neuron --------- Co-authored-by: philanthrope <[email protected]> * bump version * Faster overview pull (#1464) * first rev faster pull * use process pool instead * Contrib revamp (#1456) * revamp contrib and add more details * mention miners/validators and address feedback * update links for templates * reword PR template section making CI checks passing REQUIRED * use commit hash instead of version for representative tagging * add link to commit rule examples section * add interactive rebase and fixup mentions/examples * add tooling mentions, move rebase -i/--fixup to bottom * remove line referencing github actions * update github ISSUE_TEMPLATEs * add short description of miners and validtors * add black format check to circleCI * exclude /env * update debug to be more relevant, add tricks * address feedback RE PR steps and dev workflow * update style guide to resolve tension between atomic commits and squashing * fix torch typehint on some neurons BT-1329 (#1460) * add changelog * use double quotes for code because blackfmt * dont need this orb * add black format * no neurons in this repo !!! * rerun black * rerun black * fix casing on mock --------- Co-authored-by: joeylegere <[email protected]> Co-authored-by: “quac88” <“[email protected]”> Co-authored-by: philanthrope <[email protected]> Co-authored-by: ifrit98 <[email protected]> Co-authored-by: Mostima <[email protected]> Co-authored-by: Julius ter Pelkwijk <[email protected]> Co-authored-by: Ayden Brewer <[email protected]> Co-authored-by: Eduardo García <[email protected]> Co-authored-by: Ala Shaabana <[email protected]> Co-authored-by: Ala Shaabana <[email protected]> * fix set weights * fix null tensor * fix null tensor * fix null tensor * console * add subnetwork command * fix null shape * refactor subtensor conifg init to fix chain_endpoint setting * fix broken ass tests * rerun black * add py311 circleci test again * add synapse history log to dendrite * fix subtensor setup_config and bring back __is_set init * don't error on no content-length axon log, rerun black * explicit [] args on config call * add incentive subtensor call * . * fix typehint * fix time error and add more detailed logging into axon * bump cryptography per @Eugene-hu * add pycryptodome req back to prod * bump ansible * add testnet faucet * remove subtensor impl and add incentive func * fix type map * fix spec * fix construction of subnetinfo * remove print out * add subnet registeration cost check * run black * fix type map (#1478) * fix type map * fix spec * fix construction of subnetinfo * remove print out * run black * add netuid to register subnet * make faucet easier * fix serving rate limit check * oops * fix call to get axon info * fix parsing of value from chain * fix threadpool priority not being respected with asyncio, run black * fix subtensor mock to reflect changes in SubnetInfo * fix whitespace issue with subnet_burn_cost btcli --help cmd * remove infinite while loop in get_subnet_burn_cost() and add magic mock return value * Add subcommand support to btcli * Add __parser field to config, print subcommand help if didnt pass arg * Use subcommand config member instead of parent-command key * Move no_prompt & no_version_checking to top level parser args * Add no_prompt check to dest arg in wallet transfer * Fix default arguments suppression in config for nested subparsers * Rename SubnetBurnCost -> SubnetLockCost * Reorganize subcommand structure * [Revolution] call runtime apis using state call (#1491) * add state calls api * add overload for decoding from multiple types * use state call for neurons lite * custom registry for runtime apis / encoding params * fix usage for neurons pull * add check for 0x * remove overload * run black * remove unused utils and fix tests * run black * Fix test * deprecate python 3.8, add support for 3.11 (already testing this currently) * Add stake info runtime api (#1493) * add stake info runtime api specs * add StakeInfo to chaindata * add util function for ss58 -> Vec<u8> * use new util * add stake info query * run black * modify helpers to decode w/only typestring as well * typo * use new tuple format * run black * fix type hints for stake info funcs * typo in name of funcs * Add subnetowner to list subnets, implement root register * minor naming changes * add wallet create command * add root list * Check if user registered to root network before submitting * Add empty result error handling to query_runtime_api * subnetInfo_getBurnCost renamed to getLockCost * add stake list * stake show * Add root set weights command and extrinsic call * allow subtensor( finney or ws://127.0.0.1:9946 ) * minor changes on subnet list * fix root weights set * Use wallet submod (#1471) * add submodule for wallet * import from submodule instead * fix tests extra kwarg * add impl for bittenso_config * oops, dont return * use keyfile from submodule * use submodule instead * use submod * add CI for submodules * add submod steps to install script * update submod for a14625 * update reamde for submodule command --------- Co-authored-by: ifrit98 <[email protected]> * Revolution master merge (#1496) * remove miniupnpc * add try/except and timeout to version checking with exception handles * update CONTRIBUTING.md and DEVELOPMENT_WORKFLOW.md (#1475) * update CONTRIBUTING.md and DEVELOPMENT_WORKFLOW.md * Update contrib/DEVELOPMENT_WORKFLOW.md Co-authored-by: philanthrope <[email protected]> * move styles to style guide * update workflow doc based on comment * update contributing.md delete Architecture section * fix CODE_REVIEW_DOC dev_note link * Update contrib/CONTRIBUTING.md Great Co-authored-by: philanthrope <[email protected]> * Update contrib/CONTRIBUTING.md Ditto: Co-authored-by: philanthrope <[email protected]> --------- Co-authored-by: gitphantomman <[email protected]> Co-authored-by: philanthrope <[email protected]> * add checks (#1484) * add checks * fix docker img * fix docker img2 * only run check_requirements job when an actual requirement changes * log bittensor pipaddress for version_checking * add newline * add newline to contrib * fix formatting to 1 newline * add perms to checK-compat script * fix check_reqs ci * Update contrib/CODE_REVIEW_DOCS.md Co-authored-by: Cameron Fairchild <[email protected]> * manually add 69df50c * Revert "manually add 69df50c" This reverts commit 3b56873. Was erroneous. * remove compat check for dropped py3.8 * run black * manual add of f267fb7 * faster overview manual add: be31c49 * remove duplicate weights * run black --------- Co-authored-by: gitphantomman <[email protected]> Co-authored-by: gitphantomman <[email protected]> Co-authored-by: Cameron Fairchild <[email protected]> * add note about submodules to install from source * Fix state_call decoding error cases * Add body hash to signature for verification, stop overrides (#1503) * Add body hash to signature for verification, stop overrides * add tests * remove unused imports * remove hashlib import * missing . * [Revolution] add associated ip info (#1486) * add ipinfo to type map and chaindata * not an option * add subtensor call for pulling assoc ip * add do_associate_ips call * add encode func * black format * add state calls api * add overload for decoding from multiple types * use new state call to grab without custom rpc * oops, use correct function * add validator ip to runtimeapi registry spec * remove duplicate methods from merge and use new logic * run black --------- Co-authored-by: ifrit98 <[email protected]> * Implement sudo set hyperparameters command * Add Subnet Hyperparameters command * make config, less verbose * _SubParsersAction * add automated submodule sync to setup * add aliases * add aliases * Remove set_adjustment_interval from sudo set command * subtensor config changes * fix wallet create * Fix set hyperparameter * fix transfer command * Revolution security fix jsons (#1506) * replace pickle with jsons to avoid pickle security issues * fix test_syapse.py * use our internal msgpack-numpy that disables pickle * skip git+ reqs in check_compat * graceful error for submodules * remove jsons in favor of json, no benefit as async client (httpx) attempts to internally json deserialize anyway. jsons would be of no benefit * fix tests * remove jsons req * run black * add typehint * fix arg parse * fix overview pickling (#1508) Co-authored-by: Cameron Fairchild <[email protected]> * Revert "fix overview pickling (#1508)" This reverts commit 2cecaf9 in favor of #1509 * fix overview pickling (#1508) Co-authored-by: Cameron Fairchild <[email protected]> * [Revolution] Fix overview (#1509) * fix overview pickling * undo hacky fix * change subcmd help check. make required * fix indents with return * more explicit if/else * Revolution aio (#1488) * aiohttp * swap req for httpx/aiohttp * (WIP) * add processing on dendrite side that calls stream synapse * add example that works, fix var name * remove print statements * integrate streaming into bittensor * run black and remove examples * drop support for python<3.9 * defer to default deserialize() instead of abstractmethod, make logging stmt debug for dendrite * add client pooling for efficiency * add annotations so we don't have to use string type-hints, run black * Aio merge master (#1507) * add automated submodule sync to setup * add aliases * add aliases * Remove set_adjustment_interval from sudo set command * subtensor config changes * fix wallet create * Fix set hyperparameter * fix transfer command * Revolution security fix jsons (#1506) * replace pickle with jsons to avoid pickle security issues * fix test_syapse.py * use our internal msgpack-numpy that disables pickle * skip git+ reqs in check_compat * graceful error for submodules * remove jsons in favor of json, no benefit as async client (httpx) attempts to internally json deserialize anyway. jsons would be of no benefit * fix tests * remove jsons req * run black * fix readme, remove recurse-submod as it's in setup.py now * remove pep517 note, causes issues --------- Co-authored-by: unconst <[email protected]> Co-authored-by: Ayden Brewer <[email protected]> * merge master and update reqs * remove trace calls --------- Co-authored-by: unconst <[email protected]> Co-authored-by: Ayden Brewer <[email protected]> * run black * fix failing subtensor integration test * fix (most) test_cli unittest * run black * (WIP) fix test_cli_no_network tests * run black * remove simple checks that might change depending on python version * let subnets define schema for required body hash (#1511) * let subnets define schema for required hashable body items rather than attempting to parse * run black * add a default implementation for required_hash_fields instead of Nil * remove uused import * Revolution timeout (#1510) * add bittensor.timeout context manager, timeout substrate calls * fix try block * fix _do_set_weights call timeout * add timeouts to subtensor compose_call(s) * add display info to appropriate timeouts, fix get_transfer_fee default * catch WebsocketTimeoutException in websocket * substitute signal for threadding solution (OSX users rejoice) * reintegrate wallet (#1512) * reintegrate wallet * run black * Use state_call runtime api over node runtime calls for get_subnet_lock_cost * Remove useless blocktime sleep in SubnetLockCostCommand * Fix total_issuance column in subnet metagraph command * Revert "Revolution timeout (#1510)" (#1513) * Revert "Revolution timeout (#1510)" This reverts commit 61a16e9. * run black * fix list_delegates command * fix subnets list test by updating mock subtensor to have SubnetOwner param * add black to reqs and run it * return python 3.8 to the fold * add retries to _do calls * run black * remove submodule sync in setup as we removed submods * fix pip install to prefix with correct env for pyenv * try newer python 3.8.18 for circleci docker * try pyhton -m for install .[dev] * remove test for 3.8, it's good but circleci is broken * BIT-87 to revolution wallet upgrade (#1497) * init port of bit-87 to revolution wallet upgrade * wallet test fix * run black * formatting * added keyfileerror * added test for consistant password * formatting * separated create (legacy) wallet * commenting * fix wrong password fix * clean up * naming fix * moved UpdateWalletCommand to wallets.py * delete update_wallet.py * ux improvements * formatting * update console message * prompting message * update ux flow to make sure user have stored their mnemonics * update requirement * run black * upperbound PyNaCl req, update_wallet -> update bc we have subparsers * fix print msg * temp skip check_coinfig due to cli subparser bug, will be fixed on revolution --------- Co-authored-by: isabella618033 <[email protected]> Co-authored-by: isabella618033 <[email protected]> * Fix revolution axon blacklist (#1514) * blacklist fix * fix axon test --------- Co-authored-by: ifrit98 <[email protected]> * update signature check for blacklist * ensure required args from parsers are correctly filled from parsed args * run black * fix missed variable name for config required arg parsing * revert 98f6775 * Weight normalization (#1515) * weight normalization * run black --------- Co-authored-by: ifrit98 <[email protected]> * update blacklist signature log * Fix subnet hyperparams command by using runtime_api state_call * run black * Imports and typehints (#1517) * standardize bittensor imports * run black * standardize typehints * run black and add Calalble * add responses * fix typehints * remove unnecessary traces (#1518) * remove unnecessary traces * added blacklist reason to trace --------- Co-authored-by: isabella618033 <[email protected]> * Header fix (#1516) * (WIP) Refactor synapse and dendrite to verify body hash in signature * EUREKA! * cleanup print statements * remove (now) unnecessary metaclass override protection * remove metaclass from Synapse def * fix commit * remove print statements * run black * add typehints for request * (WIP) update synapse tests * move hash to utils * remove extra logging * fix repackaging request, inspect body and hash to compare against header hashes * remove streaming example, moved to subnet-1 template * put blacklist first so we don't load the body if we're gonna blacklist anyway * fix axon tests * fix bt. import * fix typehint bt. * fix test relative to header changes * run black * add reason to error logging * create dependency for all forward_fn routes to verify body before passing to synapse function * fix test (again) * add md5 hash option * remove extra trace * Hash fix (#1519) add check for missing field * Update allowed subnet-owner hyperparameters * Complete btcli root list command * Add dereg stake to overview command (#1495) * Add dereg stake to overview command * fix typo * use default dict instead * pass lambda for default factory * remove lambda arg in def factory * run black --------- Co-authored-by: ifrit98 <[email protected]> * Update Command Examples (#1523) Updates command examples to new format * Root Metagraph fixes (#1524) root metagraph fixes * run black * don't overwrite self.subtensor * simplify hashing for request verification (#1521) * simplify hashing for request verification * add override protection for property * run black * update synapse tests * update default json b64 value for hash_fields * remove print statement * run black * Revolution master prep (#1526) * merge master into revolution * remove depreicated content * run black * update readme for new cli (#1525) * Ci fix (#1531) * add msgpack-numpy to ci * revamp parsing to correct VCS link * Dockerfile update (#1530) update dockerfile to pytorch dep 2.0.1 * run black * Metagraph 0 fix (#1529) * fix for metagraph root weights * black * Revolution test fixes (#1528) * add no_prompt confirmation for wallet update command * fix bool flag bug in cli (argparse) * unskip tests * use instantiated subtensor for root and senate incase cli.config is None * run black * unskip and update cli tests * adds simple test for btcli root senate_vote * black --------- Co-authored-by: p-ferreira <[email protected]> * Header fix (#1532) * rm md5 -> sha3 * pass required_hash_fields as attach argument * make default_verify async * move req_hash_fields to a field instead of prop * black * make verify_body_integirty member of self to accesss required_hash_fields * correct default value * proper request name for key * update tests * black * parse required_hash_fields directly from protocol definition itself * run black * move parsing req_hash_fields below signature checks * remove arg docstring for attach() * fixes for root weights on metagraph (#1533) * fixes for root=True * run black --------- Co-authored-by: ifrit98 <[email protected]> --------- Co-authored-by: Cameron Fairchild <[email protected]> Co-authored-by: unconst <[email protected]> Co-authored-by: ifrit98 <[email protected]> Co-authored-by: CreativeBuilds <[email protected]> Co-authored-by: Cameron Fairchild <[email protected]> Co-authored-by: joeylegere <[email protected]> Co-authored-by: “quac88” <“[email protected]”> Co-authored-by: philanthrope <[email protected]> Co-authored-by: Mostima <[email protected]> Co-authored-by: Julius ter Pelkwijk <[email protected]> Co-authored-by: Ayden Brewer <[email protected]> Co-authored-by: Eduardo García <[email protected]> Co-authored-by: Ala Shaabana <[email protected]> Co-authored-by: Ala Shaabana <[email protected]> Co-authored-by: gitphantomman <[email protected]> Co-authored-by: gitphantomman <[email protected]> Co-authored-by: isabella618033 <[email protected]> Co-authored-by: isabella618033 <[email protected]> Co-authored-by: Eugene-hu <[email protected]> Co-authored-by: CreativeBuilds <[email protected]> Co-authored-by: Eugene <[email protected]> Co-authored-by: p-ferreira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the revolution companion PR for #1485