-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: l2g feature to indicate if gene is protein-coding or not #873
Conversation
@@ -81,6 +81,51 @@ def common_genecount_feature_logic( | |||
) | |||
|
|||
|
|||
def common_protein_coding_feature_logic( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is only going to be one feature, I don't see the need in having a common
function.
…1_l2g_isProteinCoding
…1_l2g_isProteinCoding
…1_l2g_isProteinCoding
Looks good to me. @ireneisdoomed please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…1_l2g_isProteinCoding
The feature is generated for each study locus, and it’s set to 1mb because, by default, VEP and other related annotation tools use this range to define potential effector genes. |
✨ Context
Adding a feature to tell l2g when a gene is protein coding or not
opentargets/issues#3509
🛠 What does this PR implement
A new feature that is either 0 or 1, for each studylocus-to-gene mapping, 1 when the gene is protein-coding, 0 otherwise.
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?