Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strings for house= field and disable Taginfo suggestions #1412

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Dimitar5555
Copy link
Contributor

@Dimitar5555 Dimitar5555 commented Dec 21, 2024

Description, Motivation & Context

Currently the house field doesn't have any strings and it shows any value with 100+ uses. This creates a lot of variants for tagging the same thing.

This PR introduces strings for the documented values of house= tag and disables Taginfo's suggestions for the field.

P.S. It doesn't affect the tag editor, I'm not sure if we can influence it.

Related issues

None

Links and data

Relevant OSM Wiki links:
https://wiki.openstreetmap.org/wiki/Key:house

Relevant tag usage stats:
https://taginfo.openstreetmap.org/keys/house#values

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 You can preview the tagging presets of this pull request here.

"options": {
"bungalow": "Bungalow",
"detached": "Detached House",
"link-detached": "Link-Detached House",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

house=link-detached has only ~750 uses and less than 20 in the building key. There isn't a preset for it in iD. It is documented though, so it might be a good idea to create a preset.

@Dimitar5555 Dimitar5555 changed the title Added strings for house= field Add strings for house= field and disable Taginfo suggestions Dec 21, 2024
@Dimitar5555
Copy link
Contributor Author

IMG_20241221_140151.jpg

(The screenshot tool doesn't want to capture the dropdown menu)

@tordans
Copy link
Collaborator

tordans commented Dec 21, 2024

I looked into houses in #1155 when I tried to understand the different wording in SC vs iD vs Wiki but never finished it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants