-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate room=class
; use room=classroom
instead
#1355
base: main
Are you sure you want to change the base?
Conversation
Bug: openstreetmap#1355 Change-Id: I90545a86f84877fea5908fd097334b87b98682e7
🍱 You can preview the tagging presets of this pull request here. |
@winstonsung I am not sure a deprecation is the right approach here to remove the tag. This came up before, so I wrote about it here https://github.com/openstreetmap/id-tagging-schema/pull/1357/files#diff-22e674f3d1da91695fbafd4d2c81f91246cfabab3d16dcf6492e6024797b4da5 We can wait for input by others to see if they would thinks this a good fit for the deprecation rules. However I suggest you look into the other methods mentioned in the linked section. |
|
Warning to others: You are not allowed to make undiscussed mass retagging internationally without following such rules https://wiki.openstreetmap.org/wiki/Automated_Edits_code_of_conduct
No less importantly, don't "wiki-fiddle"
|
So we should do it in the opposite way? |
No, you shouldn't do anything until you have asked and reached a consensus, besides following all the regulations. At least I'm indecisive on this. |
Is there any known issue that caused the bugged diagram? |
Thank you for this change! Even if this pull is not merged it's good that we at least have a tagging discrepancy resolved. I'm an avid indoor mapper so it's good to see this going somewhere. |
Bug: #1355
Change-Id: I90545a86f84877fea5908fd097334b87b98682e7
Description, Motivation & Context
"classroom" is now a conpound word and being used more frequently than the old 2-word "class room" in English language.
The page "Tag:room=classroom
" was created first.The page "Tag:room=class
" was never created as a non-redirect page.Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.