Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solved issue/1306 traffic_sign=variable_message has two direction fields #1351

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

solved issue/1306 traffic_sign=variable_message has two direction fields #1351

wants to merge 1 commit into from

Conversation

raghav3615
Copy link

Solve issue #1306 traffic_sign=variable_message has two direction fields

@github-actions GitHub Actions
Copy link

🍱 You can preview the tagging presets of this pull request here.

@raghav3615
Copy link
Author

raghav3615 commented Sep 30, 2024 •
edited
Loading

@Dimitar5555 @tordans kindly review it

Dimitar5555
Dimitar5555 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@Dimitar5555 Dimitar5555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It works as expected.

image

raghav3615
raghav3615 commented Sep 30, 2024
View reviewed changes
Copy link
Author

@raghav3615 raghav3615 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dimitar5555 can you merge it now

raghav3615
raghav3615 commented Sep 30, 2024
View reviewed changes
Copy link
Author

@raghav3615 raghav3615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge

@Dimitar5555
Copy link
Contributor

@Dimitar5555 can you merge it now

I don't have such privileges. Only Tobias, Kyle and Martin can merge PRs.

@raghav3615
Copy link
Author

raghav3615 commented Oct 1, 2024 •
edited
Loading

@tordans kindly review it and merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dimitar5555 Dimitar5555 Dimitar5555 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raghav3615 @Dimitar5555