deploy-preview: Change link to paris #1348
Conversation
Two changes - make the click target a bit bigger then "here" - add `?id=n17807753` which is Paris so users don't start at the work which in my experience is never where I do mapping
|
🍱 You can preview the tagging presets of this pull request here. |
There was a problem hiding this comment.
Hmm… I was originally thinking that starting from a global view is slightly better, because one cannot know which map features are interesting for a particular PR… So, one essentially has to search a matching test area anyway. Starting in an urban area would help for features that are common in cities, though 🤔 so, why not.
Regarding which location to choose: Maybe we can use London, as a nod to it being the birthplace of OSM? Or set it to the next host city for the SotM (Manila), and update it once a year…
Also, I'd not use the id parameter to set the starting location, but instead the map parameter (see below).
| @@ -78,7 +78,7 @@ jobs: | |||
| owner: context.repo.owner, | |||
| repo: context.repo.repo, | |||
| issue_number: pullRequestNumber, | |||
| body: `${start} You can preview the tagging presets of this pull request [here](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#locale=en).` | |||
| body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/?id=n17807753#locale=en).` | |||
There was a problem hiding this comment.
The standalone version of iD does only look at the hash part of the url:
| body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/?id=n17807753#locale=en).` | |
| body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#id=n17807753&locale=en).` |
But for the above mentioned alternatives, using the map parameter would be more appropriate:
| body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/?id=n17807753#locale=en).` | |
| body: `${start} You can preview the tagging presets of this pull request [in this deploy preview](https://pr-${pullRequestNumber}--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=17.00/14.65485/121.06466).` |
This change the deploy preview link by adding
?id=n17807753which is Paris so users don't start at the work which in my experience is never where I do mapping.My idea is, that it is quicker and easier to review PRs when I don't have to find a node or way to see the changes, first.
We can pick any location…
[Example](https://pr-1344--ideditor-presets-preview.netlify.app/id/dist/?id=n17807753#locale=en
Another change is to make the click target bigger than the short "here".