-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add panoramax=*
universal field
#1344
base: main
Are you sure you want to change the base?
Conversation
🍱 You can preview the tagging presets of this pull request here. |
Tested, and seems to work fine! (i.e. I can search for |
@mnalis You rock! :D |
I wonder if we should take this opportunity and look into how we can improve the Usability for those fields…
Mapillary: Wiki, Wikidata item On the general question of when / if to merge this: I don't see a reason why not other than other image street level image services are out there and they did not ask, yet. — But given this is a global key, I would like to wait for a +1 from another co-maintainer. |
I like the idea of street_level_imagery:panoramax=id since it's clearer and self-documenting. Imo, "picture identifier" is ideal since it reflects the Panoramax UI: I have also updated the wiki with instructions on how to retrieve the picture identifier in Panoramax. @PanierAvide can you please comment on whether it is expected for panoramax=* to only store one picture ID with no semicolon usage? My guess is yes. If so, we can add the line to the wiki: "Each image only has one picture identifier, so panoramax=* may only contain one UUID value. Multiple values are not permitted." |
My two cents on the topic :
|
@tyrasd What are your thought on …
|
Using Another thing to keep in mind: a panoramax-hash is 37 characters long. This means that at most 6 images are supported because of the 255 character limit in OpenStreetMap. MapComplete instead uses |
@pietervdvn I don't think the intention was to introduce a new While generally that might be a good idea (especially if the amount of such street-imagery keys were to grow) , I personally don't think it is quite necessary at this time, so should not be blocking this PR.
That sounds like a good idea to me (as multiple values are documented to be allowed there), but implementation of that (if accepted) is likely (again) going to be separate PR implementing this feature for all streetview-alike keys, so should not be blocking this panoramax-oriented PR. Over 99.8% of the |
I'm fine with both @tordans. I'd just suggest keeping it the same for both keys. "Picture identifier (ID / Key)" sounds reasonable to me. If you prefer, I can change both
I've not seen any opposition for this PR in several months (only likes), so I'd say it is good to go. |
Description, Motivation & Context
This PR adds
panoramax=*
universal field which contains UUID of the photo in Panoramax.Panoramax is FOSS decentralized federated map of geolocated street-level pictures. Its function is similar to Facebook's Mapillary (which has universal
mapillary=*
already in id-tagging-schema) or Google StreetView, but with emphasis on being fully open-source stack and allowing decentralization.(i.e. Panoramax is alternative to Mapillary/GoogleStreetView in much the same way as Mastodon is alternative to Twitter/X, thus more aligned with OpenStreetMap premises).
Related issues
Closes #1334
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Current usage (as of the creating this PR) is 1583 uses, and taginfo shows a fast growing curve.
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.