-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add operator:type=public|private|nil
to some highway
presets
#1310
base: main
Are you sure you want to change the base?
Conversation
🍱 You can preview the tagging presets of this pull request here. |
Test-DocumentationPreview links & Sidebar ScreenshotsOverpass: https://overpass-turbo.eu/s/1Px6 It also works if other values than the three defined values are used: SearchInfo-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As others mentioned, the usage is currently quite low (relative to all mapped roads), but I do see the value to be able to explicitly map privately maintained roads (e.g. driveways, footpaths in large apartment complexes, service roads in industrial sites, etc.). Interestingly, there is a lack of documentation for this usage on the wiki. Maybe it should be added there as well in addition to this PR?!
I'm unsure about the implementation as a checkbox field: how iD interprets the tag values as checkbox states, both tag values get the checkmark ☑️ symbol, which is confusing. Given that the private operator state is the much more "informative" state, and operator:type=public
generally is (and should?) not be mapped explicitly: Maybe it can be simplified to a defaultCheck
field; see the matching suggestion below.
Lastly, the label "Operator Type" feels to be a bit too much like OSM-tagging lingo. 😅 Does one even operate a road (except maybe if it's a toll road)?! Isn't the information on is actually tagging here: Who is responsible for the maintenance of the road and/or who owns the the road?
"type": "check", | ||
"label": "Operator Type", | ||
"strings": { | ||
"options": { | ||
"public": "Public (Default)", | ||
"private": "Private", | ||
"undefined": "Assumed Public" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(potential suggestion for the comment above)
"type": "check", | |
"label": "Operator Type", | |
"strings": { | |
"options": { | |
"public": "Public (Default)", | |
"private": "Private", | |
"undefined": "Assumed Public" | |
"type": "defaultCheck", | |
"label": "Road Maintenance", | |
"strings": { | |
"options": { | |
"undefined": "Public Entity", | |
"private": "Private" |
Description, Motivation & Context
See #1304
This is build using a
check
field type and adding custom values to the three check states as described in https://github.com/ideditor/schema-builder?tab=readme-ov-file#strings An existing example of this would be https://github.com/openstreetmap/id-tagging-schema/blob/2375a6b/data/fields/parcel_pickup.jsonThe idea is, that for highways really only those three values (
public
,private
,<novalue>
) are relevant.The field is in
moreFields
so it only shows if data is present or users really look for it.Related issues
Closes #1304
Links and data
See #1304
Relevant tag usage stats:
See #1304
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.