Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator:type=public|private|nil to some highway presets #1310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Aug 10, 2024

Description, Motivation & Context

See #1304

This is build using a check field type and adding custom values to the three check states as described in https://github.com/ideditor/schema-builder?tab=readme-ov-file#strings An existing example of this would be https://github.com/openstreetmap/id-tagging-schema/blob/2375a6b/data/fields/parcel_pickup.json

The idea is, that for highways really only those three values (public, private, <novalue>) are relevant.

The field is in moreFields so it only shows if data is present or users really look for it.

Related issues

Closes #1304

Links and data

See #1304

Relevant tag usage stats:
See #1304

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 You can preview the tagging presets of this pull request here.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/tordans/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

Copy link

🍱 You can preview the tagging presets of this pull request here.

@tordans
Copy link
Collaborator Author

tordans commented Aug 10, 2024

Test-Documentation

Preview links & Sidebar Screenshots

Overpass: https://overpass-turbo.eu/s/1Px6

Example: https://pr-1310--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w62543974&locale=en&map=19.10/52.48950/13.41641

image image image

It also works if other values than the three defined values are used:
image
But I consider this very uncommon for highways.

Search

Search for the field
image

Info-i

Das ist sehr generisch und nicht sehr hilfreich.

image

Ich habe es aber etwas angepasst. https://wiki.openstreetmap.org/wiki/Item:Q526

Man könnte noch über Suchwörter wie "Road Authority" (DE: "Straßenbaulastträger") nachdenken.

Wording

  • American English
  • name, aliases (if present) use Title Case
  • terms (if present) use lower case, sorted A-Z

Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As others mentioned, the usage is currently quite low (relative to all mapped roads), but I do see the value to be able to explicitly map privately maintained roads (e.g. driveways, footpaths in large apartment complexes, service roads in industrial sites, etc.). Interestingly, there is a lack of documentation for this usage on the wiki. Maybe it should be added there as well in addition to this PR?!

I'm unsure about the implementation as a checkbox field: how iD interprets the tag values as checkbox states, both tag values get the checkmark ☑️ symbol, which is confusing. Given that the private operator state is the much more "informative" state, and operator:type=public generally is (and should?) not be mapped explicitly: Maybe it can be simplified to a defaultCheck field; see the matching suggestion below.

Lastly, the label "Operator Type" feels to be a bit too much like OSM-tagging lingo. 😅 Does one even operate a road (except maybe if it's a toll road)?! Isn't the information on is actually tagging here: Who is responsible for the maintenance of the road and/or who owns the the road?

Comment on lines +3 to +9
"type": "check",
"label": "Operator Type",
"strings": {
"options": {
"public": "Public (Default)",
"private": "Private",
"undefined": "Assumed Public"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(potential suggestion for the comment above)

Suggested change
"type": "check",
"label": "Operator Type",
"strings": {
"options": {
"public": "Public (Default)",
"private": "Private",
"undefined": "Assumed Public"
"type": "defaultCheck",
"label": "Road Maintenance",
"strings": {
"options": {
"undefined": "Public Entity",
"private": "Private"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add operator:type to highways
2 participants