Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add ignore_issue if there are no other dynamic fixes, tries to fix #10614 #10632

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Do not add ignore_issue if there are no other dynamic fixes, tries to fix #10614 #10632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/core/validation/models.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export function validationIssue(attrs) {
var fixes = this.dynamicFixes ? this.dynamicFixes(context) : [];
var issue = this;

if (issue.severity === 'warning') {
if (issue.severity === 'warning' && fixes.length > 0) {
// allow ignoring any issue that's not an error
fixes.push(new validationIssueFix({
title: t.append('issues.fix.ignore_issue.title'),
Expand Down
Loading