Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial reconciler methods for WatcherApplier #49

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Add initial reconciler methods for WatcherApplier #49

merged 1 commit into from
Jan 27, 2025

Conversation

viroel
Copy link
Contributor

@viroel viroel commented Jan 21, 2025 •
edited
Loading

Adds initial logic for reconciler on Watcher Applier controller, including inputs, serviceConfig and memcached configurations.

@openshift-ci openshift-ci bot requested review from raukadah and rlandy January 21, 2025 20:21
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d138bcc07e3448f39e4d6ee65398da0c

✔️ noop SUCCESS in 0s
✔️ openstack-meta-content-provider SUCCESS in 1h 30m 47s
✔️ watcher-operator-validation SUCCESS in 1h 19m 37s
❌ watcher-operator-kuttl RETRY_LIMIT in 30m 03s

@viroel viroel force-pushed the applier_controller branch from 5c86430 to 6e60478 Compare January 23, 2025 19:40
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/watcher-operator for 49,6e604783a0248858b56325251a56b883a7ce92c0

@viroel viroel force-pushed the applier_controller branch from 6e60478 to 55bf155 Compare January 24, 2025 11:26
@viroel viroel force-pushed the applier_controller branch from 55bf155 to 1f49d2d Compare January 24, 2025 12:06
amoralej
amoralej reviewed Jan 24, 2025
View reviewed changes
Copy link
Contributor

@amoralej amoralej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Other than that, just add a base kuttl scenario for watcherapplier (new folder in https://github.com/openstack-k8s-operators/watcher-operator/tree/main/tests/kuttl/test-suites/default ) and it'd be ready to merge imo.

api/v1beta1/watcherapplier_types.go Outdated Show resolved Hide resolved
@viroel viroel force-pushed the applier_controller branch from 1f49d2d to fb418c3 Compare January 24, 2025 19:37
@viroel viroel changed the title WIP - Add initial reconciler methods for WatcherApplier Add initial reconciler methods for WatcherApplier Jan 24, 2025
amoralej
amoralej reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@amoralej amoralej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of tests about kuttl tests.

tests/kuttl/test-suites/default/watcher-applier/02-deploy-with-defaults.yaml Outdated Show resolved Hide resolved
tests/kuttl/test-suites/default/watcher-applier/03-deploy-with-defaults.yaml Outdated Show resolved Hide resolved
@viroel viroel force-pushed the applier_controller branch from fb418c3 to a04a8e8 Compare January 27, 2025 11:51
@viroel
Add initial reconciler methods for WatcherApplier
91bc859 
Adds initial logic for reconciler on Watcher Applier controller,
including inputs, serviceConfig and memcached configurations.
@viroel viroel force-pushed the applier_controller branch from a04a8e8 to 91bc859 Compare January 27, 2025 11:54
@openshift-ci openshift-ci bot added the lgtm label Jan 27, 2025
@amoralej
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amoralej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6f7cbc9 into openstack-k8s-operators:main Jan 27, 2025
6 checks passed
@viroel viroel deleted the applier_controller branch January 28, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoralej amoralej amoralej left review comments

@cescgina cescgina cescgina approved these changes

@raukadah raukadah Awaiting requested review from raukadah

@rlandy rlandy Awaiting requested review from rlandy

Assignees

@cescgina cescgina

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viroel @amoralej @cescgina @openshift-merge-robot