Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic reconcile methods for WatcherDecisionEngine #44

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Add basic reconcile methods for WatcherDecisionEngine #44

merged 2 commits into from
Jan 28, 2025
+858 −7

Conversation

marios
Copy link
Contributor

@marios marios commented Jan 17, 2025 •
edited
Loading

Add basic reconcile methods for WatcherDecisionEngine

Adds the basic attributes to the WatcherDecisionEngineSpec and Status
structs (like WatcherCommon) and adds the basic reconcile functions
like GetLogger and initStatus and skeleton for generateServiceConfigs

Includes base unit tests and next commit will have kuttl.

Adds basic kuttl test for WatcherDecisionEngine

The parent commit adds the initial reconcile functions and
this adds some kuttl coverage. The DecisionEngine is not yet
integrated with the top-level Watcher so for now creating a
new directory which can be moved later.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/watcher-operator for 44,0c079bf2e99cfcc02f30bd2a3847c04ffbca303a

@marios marios mentioned this pull request Jan 20, 2025
Merged
marios
marios commented Jan 20, 2025
View reviewed changes
Copy link
Contributor Author

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update incoming for merge conflict

@marios marios force-pushed the decision_engine_init branch from 0c079bf to 8e9c64a Compare January 20, 2025 11:43
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/27a85de2461345948a46a0cc7c88cd25

✔️ noop SUCCESS in 0s
✔️ openstack-meta-content-provider SUCCESS in 1h 29m 55s
✔️ watcher-operator-validation SUCCESS in 1h 19m 19s
❌ watcher-operator-kuttl RETRY_LIMIT in 30m 06s

@marios marios force-pushed the decision_engine_init branch from 8e9c64a to 8fe1870 Compare January 21, 2025 15:39
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/watcher-operator for 44,8fe18704e60f9632b8d699c8165cab9471f14c82

@marios marios force-pushed the decision_engine_init branch from 8fe1870 to 678139a Compare January 21, 2025 15:42
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d0872c33c33d42b88533af993205c416

✔️ noop SUCCESS in 0s
✔️ openstack-meta-content-provider SUCCESS in 1h 34m 21s
✔️ watcher-operator-validation SUCCESS in 1h 22m 38s
❌ watcher-operator-kuttl RETRY_LIMIT in 29m 46s

marios
marios commented Jan 22, 2025
View reviewed changes
Copy link
Contributor Author

@marios marios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your comments amoralej

controllers/watcherdecisionengine_controller.go Outdated Show resolved Hide resolved
controllers/watcherdecisionengine_controller.go Show resolved Hide resolved
controllers/watcherdecisionengine_controller.go Outdated Show resolved Hide resolved
controllers/watcherdecisionengine_controller.go Outdated Show resolved Hide resolved
controllers/watcherdecisionengine_controller.go Show resolved Hide resolved
tests/functional/watcherdecisionengine_controller_test.go Outdated Show resolved Hide resolved
tests/functional/watcherdecisionengine_controller_test.go Show resolved Hide resolved
@marios marios force-pushed the decision_engine_init branch from 678139a to 83ddd5c Compare January 22, 2025 15:42
@marios marios force-pushed the decision_engine_init branch from 83ddd5c to 0962062 Compare January 24, 2025 15:12
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d9231b2a33d1439e9159a13c4917dffe

✔️ noop SUCCESS in 0s
✔️ openstack-meta-content-provider SUCCESS in 1h 26m 51s
✔️ watcher-operator-validation SUCCESS in 1h 15m 35s
❌ watcher-operator-kuttl FAILURE in 38m 59s

@marios marios force-pushed the decision_engine_init branch from 0962062 to 7fee7db Compare January 27, 2025 09:35
@marios
Copy link
Contributor Author

marios commented Jan 27, 2025

kuttl test needs another iteration but otherwise i think ready for review when you next have time please @amoralej @cescgina

@marios marios marked this pull request as ready for review January 27, 2025 09:36
@openshift-ci openshift-ci bot requested a review from dprince January 27, 2025 09:36
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3a310445b6c1420391d15bbdff29e1a2

✔️ noop SUCCESS in 0s
✔️ openstack-meta-content-provider SUCCESS in 1h 24m 20s
✔️ watcher-operator-validation SUCCESS in 1h 13m 14s
❌ watcher-operator-kuttl FAILURE in 40m 42s

@marios marios force-pushed the decision_engine_init branch from 7fee7db to 5506a05 Compare January 27, 2025 15:07
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/watcher-operator for 44,5506a0593610de964c261c11a4c365ceb39d7342

@marios marios force-pushed the decision_engine_init branch from 5506a05 to 63bfc26 Compare January 27, 2025 15:10
@marios marios force-pushed the decision_engine_init branch from 63bfc26 to ae483af Compare January 27, 2025 15:49
@cescgina
Copy link
Contributor

Left a couple of very minor comments, but this is very close to be good to go now

@marios marios force-pushed the decision_engine_init branch from ae483af to 6f9d2f0 Compare January 27, 2025 16:31
marios added 2 commits January 28, 2025 09:46
@marios
Add basic reconcile methods for WatcherDecisionEngine
8311045 
Adds the basic attributes to the WatcherDecisionEngineSpec and Status
structs (like WatcherCommon) and adds the basic reconcile functions
like GetLogger and initStatus and skeleton for generateServiceConfigs

Includes base unit tests and next commit will have kuttl.
@marios
Adds basic kuttl test for WatcherDecisionEngine
5da3c0f 
The parent commit adds the initial reconcile functions and
this adds some kuttl coverage. The DecisionEngine is not yet
integrated with the top-level Watcher so for now creating a
new directory which can be moved later.
@marios marios force-pushed the decision_engine_init branch from 6f9d2f0 to 5da3c0f Compare January 28, 2025 07:56
@cescgina
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amoralej
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 28, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b9599e7 into openstack-k8s-operators:main Jan 28, 2025
6 checks passed
marios added a commit to marios/watcher-operator that referenced this pull request Feb 4, 2025
@marios
WIP adds config and deployment for WatcherDecisionEngine
5c12060 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] openstack-k8s-operators#44
@marios marios mentioned this pull request Feb 4, 2025
Merged
marios added a commit to marios/watcher-operator that referenced this pull request Feb 4, 2025
@marios
WIP adds config and deployment for WatcherDecisionEngine
c29b0ba 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] openstack-k8s-operators#44
marios added a commit to marios/watcher-operator that referenced this pull request Feb 5, 2025
@marios
WIP adds config and deployment for WatcherDecisionEngine
0901a50 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] openstack-k8s-operators#44
marios added a commit to marios/watcher-operator that referenced this pull request Feb 5, 2025
@marios
WIP adds config and deployment for WatcherDecisionEngine
633ed9b 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] openstack-k8s-operators#44
marios added a commit to marios/watcher-operator that referenced this pull request Feb 6, 2025
@marios
Adds config and deploys StatefulSet for WatcherDecisionEngine
9ecdeb7 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] openstack-k8s-operators#44
marios added a commit to marios/watcher-operator that referenced this pull request Feb 6, 2025
@marios
Adds config and deploys StatefulSet for WatcherDecisionEngine
154b808 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] openstack-k8s-operators#44
marios added a commit to marios/watcher-operator that referenced this pull request Feb 7, 2025
@marios
Adds config and deploys StatefulSet for WatcherDecisionEngine
ecd5671 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] openstack-k8s-operators#44
openshift-merge-bot bot pushed a commit that referenced this pull request Feb 7, 2025
@marios @openshift-merge-bot
Adds config and deploys StatefulSet for WatcherDecisionEngine
ef0d4f9 
This follows on from [1] to add missing configuration collection
and creation of a StatefulSet for the DecisionEngine.

[1] #44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoralej amoralej amoralej requested changes

@viroel viroel viroel left review comments

@cescgina cescgina cescgina left review comments

@dprince dprince Awaiting requested review from dprince

@kopecmartin kopecmartin Awaiting requested review from kopecmartin

Assignees

@amoralej amoralej

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marios @cescgina @amoralej @viroel @openshift-merge-robot