Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration files for CI #4

Merged

Conversation

cescgina
Copy link
Contributor

Add configuration files for pre-commit, ci-operator and golangci to be
able to run pre-commit in PRs via prow.

Copy link

@kopecmartin kopecmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@cescgina cescgina closed this Nov 11, 2024
@cescgina cescgina deleted the add_precommit_ci_operator branch November 11, 2024 14:24
@cescgina cescgina restored the add_precommit_ci_operator branch November 12, 2024 10:21
@cescgina cescgina reopened this Nov 12, 2024
Add configuration files for pre-commit, ci-operator and golangci to be
able to run pre-commit in PRs via prow.
@SeanMooney
Copy link
Collaborator

if i run this locally it modifeis the repo and fails

https://termbin.com/0ymt

can you update the pr to correct the issues

@cescgina
Copy link
Contributor Author

if i run this locally it modifeis the repo and fails

https://termbin.com/0ymt

can you update the pr to correct the issues

sure, updated the PR with the fixes

@SeanMooney
Copy link
Collaborator

this still locally modifes go.mod and go.sum

https://termbin.com/00cx

- Remove test files added by openstack sdk
- Add a temporary access to the req variable in the Reconcile function
  in watcherapi_controller
- Fix end-of-file for multiple files
@cescgina cescgina force-pushed the add_precommit_ci_operator branch from 23fb1ef to a4049ec Compare November 12, 2024 13:32
@SeanMooney SeanMooney merged commit f11de13 into openstack-k8s-operators:main Nov 12, 2024
2 checks passed
@cescgina cescgina deleted the add_precommit_ci_operator branch November 12, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants