Add secret and services to controller rbac #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
/approve |
While trying to run kuttl tests in [1], we get an error [2] stating that the watcher controller does not have access to secrets. This change adds the required kubebuilder annotations for secrets in the watcher controller. Similarly, we are also missing access to services [3]. [1] openstack-k8s-operators#14 [2] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/12efc41/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-84c899877f-wjsx8/logs/manager.log # Please enter the commit message for your changes. Lines starting [3] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/1968261/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-67dbb9c5d5-t25z6/logs/manager.log
cescgina
force-pushed
the
add_secret_rbac_watcher_controller
branch
from
9d3d55d to
d699c63
Compare
cescgina
changed the title
|
/unhold kuttl job in https://softwarefactory-project.io/zuul/t/rdoproject.org/build/6ed0fe8ce7ed433ca20ec7bbd71e9095 is green with this as depends-on ( via #14) |
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amoralej The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm thank you @cescgina for adding the kuttl job link. |
openshift-merge-bot
bot
merged commit 011339a
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to run kuttl tests in [1], we get an error [2]
stating that the watcher controller does not have access to secrets.
This change adds the required kubebuilder annotations for secrets in the
watcher controller. Similarly, we are also missing access to services
[3].
[1] #14
[2] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/12efc41/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-84c899877f-wjsx8/logs/manager.log
[3] https://logserver.rdoproject.org/14/14/693d9a4c2c6b2630ef004bcd34b0bf3076826174/github-check/watcher-operator-kuttl/1968261/controller/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack-operators/pods/watcher-operator-controller-manager-67dbb9c5d5-t25z6/logs/manager.log