Fix watcher sample CR #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is missing the minimal `databaseInstance` field so it is failing to deploy. I'm also renaming it to `watcher`.
|
For reference to the error in CI: |
|
/lgtm |
SeanMooney
previously requested changes
Nov 28, 2024
This patch is adding a functional test to validate the Watcher sample. This test whould have uncovered the previous issue with samples. Note that this is only validating the Watcher CRD sample. For the rest, we will add it while creating the basic structrue for each one.
SeanMooney
reviewed
Nov 29, 2024
SeanMooney
approved these changes
Nov 29, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cescgina The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 46968a0
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is missing the minimal
databaseInstancefield so it is failing to deploy.I'm also renaming it to
watcher.