-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create TransportURL from the watcher controller #16
Create TransportURL from the watcher controller #16
Conversation
This Patch is creating the required RabbitMQ infra via TransportURL CR. - It adds RabbitMqClusterName param to the spec and WatcherRabbitMQTransportURLReadyCondition to the conditions list. - It adds logic to the watcher controller to create a TransportURL object from rabbitmq in infra-operator. - Adds functional envtest tests for the added feature.
(cherry picked from commit 2a14a38)
For consistency with WatcherAPI ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm @amoralej One question Do we want to integrate |
It has a meaningful default value which matches the default openstackcontrolplane installation, so I'd say we don't need to add it to the sample. Although I could if there is any reason to do it. |
Yes, correct, the default value of |
/approve there are several lgtm to already |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cescgina The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
261e29f
into
openstack-k8s-operators:main
This patch is adding the rabbitmq TransportURL from the watcher controller.
it is also creating the functional envtest and kuttl tests.
Related: OSPRH-11422