Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Logging configuration to telemetry-operator #241

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Added Logging configuration to telemetry-operator #241

merged 4 commits into from
Nov 27, 2023

Conversation

jlarriba
Copy link
Collaborator

No description provided.

@jlarriba jlarriba force-pushed the logging branch 2 times, most recently from cbf24dc to 7230e75 Compare November 21, 2023 11:11
vyzigold
vyzigold reviewed Nov 22, 2023
View reviewed changes
Copy link
Contributor

@vyzigold vyzigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be a good idea to add this to the kuttl test suite?

controllers/logging_controller.go Show resolved Hide resolved
controllers/logging_controller.go Outdated Show resolved Hide resolved
controllers/logging_controller.go Show resolved Hide resolved
controllers/logging_controller.go Outdated Show resolved Hide resolved
controllers/logging_controller.go Outdated Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5efd1b2949c749b8bbec199b3e0c425a

❌ openstack-k8s-operators-content-provider FAILURE in 8m 05s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@jlarriba
Copy link
Collaborator Author

Wouldn't it be a good idea to add this to the kuttl test suite?

Yes indeed, working on it.

@jlarriba jlarriba force-pushed the logging branch 3 times, most recently from c08de16 to b3172a1 Compare November 22, 2023 14:59
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6925d56bce354b9b9062264fedea9e18

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 24s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 13m 17s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a09a8dad7e774b8c89e164ec1fa25a34

✔️ openstack-k8s-operators-content-provider SUCCESS in 27m 51s
❌ podified-multinode-edpm-deployment-crc NODE_FAILURE Node request 199-0006664601 failed in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6e73d97afe90422cbfb7b77e02db05f8

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 200-0006664633 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@jlarriba
Copy link
Collaborator Author

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3bc203bd2e9a48debc46f4da81b49261

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 200-0006664670 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@paramite
Copy link
Contributor

/retest

1 similar comment
@jlarriba
Copy link
Collaborator Author

/retest

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a0eb3b165cc643f4a48cf96c5d24015b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 06s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 15m 06s

@jlarriba jlarriba force-pushed the logging branch 2 times, most recently from 1647268 to 9995471 Compare November 24, 2023 15:50
@jlarriba
Copy link
Collaborator Author

/retest

vyzigold
vyzigold reviewed Nov 27, 2023
View reviewed changes
api/v1beta1/logging_types.go Outdated Show resolved Hide resolved
controllers/logging_controller.go Show resolved Hide resolved
controllers/logging_controller.go Show resolved Hide resolved
@jlarriba jlarriba force-pushed the logging branch 2 times, most recently from ad91246 to e7a8e23 Compare November 27, 2023 10:48
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2f9a49f7fa1944178090affc02ac00bf

✔️ openstack-k8s-operators-content-provider SUCCESS in 18m 13s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 6s

@jlarriba
Copy link
Collaborator Author

recheck

@openshift-ci openshift-ci bot added the lgtm label Nov 27, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlarriba, vyzigold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a5f3ba0 into openstack-k8s-operators:main Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzigold vyzigold vyzigold approved these changes

@paramite paramite Awaiting requested review from paramite

@abays abays Awaiting requested review from abays

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@yadneshk yadneshk Awaiting requested review from yadneshk

Assignees

@vyzigold vyzigold

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlarriba @paramite @vyzigold