-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KUTTL tests for Ceilometer and Telemetry API #232
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paramite The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise this LGTM, although I don't know much about kuttl
@@ -0,0 +1,33 @@ | |||
apiVersion: operators.coreos.com/v1alpha1 | |||
kind: CatalogSource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I should note, that in the future, I think we might want to use the OBO from the community-operators instead of using a custom catalog source. I tried to use it while developing the autoscaling without success and it seems there is still the same version, which didn't seem to work for me back then (0.0.25) while in the OBO repo I see latest version 0.0.28. So there is nothing to do now, just something to keep in mind in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed. This is just a workaround to make it work now.
/lgtm |
apiImage: "quay.io/mmagr/openstack-aodh-api:current-podified" | ||
evaluatorImage: "quay.io/mmagr/openstack-aodh-evaluator:current-podified" | ||
notifierImage: "quay.io/mmagr/openstack-aodh-notifier:current-podified" | ||
listenerImage: "quay.io/mmagr/openstack-aodh-listener:current-podified" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there another source besides a personal repo for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature in aodh needs to be backported from master to 2023.1 for us to be able to actually use it. But if we are just checking that deployments and services are created, then it shouldn't matter which images we use and we should indeed probably use the antelope images here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the time of writing the tests Aodh and Heat patches were still on review. These days images built with master branches of both should have the autoscaling bits in. Backporting to stable/antelope will be a bit problematic though, and maybe impossible. As far as [1] is saying we cannot backport new feature (Heat, Aodh) nor new dependency (python-observabilityclient) on upstream side. My thought was to create a TCIB fork with a GH actions workflow, which will build images and push to quay.io/infrawatch on regular basis.
[1] https://docs.openstack.org/project-team-guide/stable-branches.html#active-maintenance (point 1.)
/retest |
1 similar comment
/retest |
/lgtm |
Adds remaining KUTTL suites and sets default suite to test Telemetry CR.