Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUTTL tests for Ceilometer and Telemetry API #232

Merged
merged 8 commits into from
Nov 14, 2023

Conversation

paramite
Copy link
Contributor

Adds remaining KUTTL suites and sets default suite to test Telemetry CR.

Copy link
Contributor

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paramite

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@vyzigold vyzigold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this LGTM, although I don't know much about kuttl

Makefile Outdated Show resolved Hide resolved
@@ -0,0 +1,33 @@
apiVersion: operators.coreos.com/v1alpha1
kind: CatalogSource
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should note, that in the future, I think we might want to use the OBO from the community-operators instead of using a custom catalog source. I tried to use it while developing the autoscaling without success and it seems there is still the same version, which didn't seem to work for me back then (0.0.25) while in the OBO repo I see latest version 0.0.28. So there is nothing to do now, just something to keep in mind in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed. This is just a workaround to make it work now.

@jlarriba
Copy link
Collaborator

/lgtm

Comment on lines +12 to +15
apiImage: "quay.io/mmagr/openstack-aodh-api:current-podified"
evaluatorImage: "quay.io/mmagr/openstack-aodh-evaluator:current-podified"
notifierImage: "quay.io/mmagr/openstack-aodh-notifier:current-podified"
listenerImage: "quay.io/mmagr/openstack-aodh-listener:current-podified"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another source besides a personal repo for these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature in aodh needs to be backported from master to 2023.1 for us to be able to actually use it. But if we are just checking that deployments and services are created, then it shouldn't matter which images we use and we should indeed probably use the antelope images here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the time of writing the tests Aodh and Heat patches were still on review. These days images built with master branches of both should have the autoscaling bits in. Backporting to stable/antelope will be a bit problematic though, and maybe impossible. As far as [1] is saying we cannot backport new feature (Heat, Aodh) nor new dependency (python-observabilityclient) on upstream side. My thought was to create a TCIB fork with a GH actions workflow, which will build images and push to quay.io/infrawatch on regular basis.

[1] https://docs.openstack.org/project-team-guide/stable-branches.html#active-maintenance (point 1.)

@jlarriba jlarriba removed the lgtm label Nov 13, 2023
@paramite
Copy link
Contributor Author

/retest

1 similar comment
@paramite
Copy link
Contributor Author

/retest

@jlarriba
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 5a92493 into main Nov 14, 2023
9 checks passed
@paramite paramite deleted the telemetry-kuttl branch November 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants