Improve error handling #265
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
/test precommit-check |
ref OSPRH-9329 Signed-off-by: Fabricio Aguiar <[email protected]>
|
/test precommit-check |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/64db1081e5954319a2397e2b6be2fa06 ✔️ openstack-baremetal-operator-content-provider SUCCESS in 2h 06m 45s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a4214ce164be40f5aa980abaa3db239b ✔️ openstack-baremetal-operator-content-provider SUCCESS in 1h 34m 20s |
|
recheck |
| @@ -128,7 +128,7 @@ func runChecksumStartCmd(_ *cobra.Command, _ []string) { | |||
| } | |||
|
|
|||
| if checksumFileName == "" { | |||
| panic(fmt.Errorf("could not find any OSImage checksum file in %s", checksumStartOpts.osImageDir)) | |||
| panic(fmt.Errorf("%w in %s", ErrOSImageNotFound, checksumStartOpts.osImageDir)) | |||
There was a problem hiding this comment.
Hmm.. Does err113 linter crib only for this one? We use it everywhere[1]. Realistically neither we compare the error anywhere nor there is memory related optimization, as it's used only once.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fao89, rabi, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 929e660
into
openstack-k8s-operators:main
ref OSPRH-9329