Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraMounts functional tests #374

Merged

Conversation

fmount
Copy link
Collaborator

@fmount fmount commented Dec 9, 2024

This change adds a functional test for the Manila extraMounts. It ensures we're able to validate the abstraction of corev1.VolumeSource struct introduced in lib-common/storage module.

Jira: https://issues.redhat.com/browse/OSPRH-11210

@fmount fmount requested a review from gouthampacha December 9, 2024 12:39
@openshift-ci openshift-ci bot requested review from abays and frenzyfriday December 9, 2024 12:39
@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
This change adds a functional test for the Manila extraMounts. It
ensures we're able to validate the abstraction of 'corev1.VolumeSource'
struct introduced in lib-common/storage module.

Jira: https://issues.redhat.com/browse/OSPRH-11210

Signed-off-by: Francesco Pantano <[email protected]>
Copy link
Contributor

@gouthampacha gouthampacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thank you @fmount

Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, gouthampacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fmount,gouthampacha]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 33696c8 into openstack-k8s-operators:main Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants