Move GlanceAPI deployment to Statefulset #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmount
force-pushed
the
statefulset
branch
2 times, most recently
from
833240c to
4167c2d
Compare
|
/retest |
Signed-off-by: Francesco Pantano <[email protected]>
This patch improves the way the glance statefulset uses PVCs:
- ensurePVC is not required anymore and the logic has been moved away
from controller to the statefulset creation function
- storage{class, Request} are now fields of the GlanceAPITemplate
- getVolumes don't require the pvc anymore
Signed-off-by: Francesco Pantano <[email protected]>
fmount
force-pushed
the
statefulset
branch
3 times, most recently
from
fda8e38 to
332e407
Compare
fmount
changed the title
fultonj
added a commit
to fultonj/architecture
that referenced
this pull request
Oct 31, 2023
We will restore this after the following merges. openstack-k8s-operators/glance-operator#352 Signed-off-by: John Fulton <[email protected]>
fultonj
added a commit
to fultonj/architecture
that referenced
this pull request
Oct 31, 2023
In the current implemenation this is causing pods to get stuck in pending. Remove until we can implement correctly after the following merges. openstack-k8s-operators/glance-operator#352 Signed-off-by: John Fulton <[email protected]>
fmount
commented
Nov 2, 2023
| @@ -167,12 +167,6 @@ type GlanceStatus struct { | |||
|
|
|||
| // Glance Database Hostname | |||
| DatabaseHostname string `json:"databaseHostname,omitempty"` | |||
|
|
|||
| // ReadyCount of internal and admin Glance API instance | |||
| GlanceAPIInternalReadyCount int32 `json:"glanceAPIInternalReadyCount,omitempty"` | |||
There was a problem hiding this comment.
@abays this is not required anymore w/ statefulset (same story with the other parameter)
fmount
commented
Nov 2, 2023
| @@ -4,7 +4,7 @@ metadata: | |||
| name: image-import-staging-workspace | |||
| spec: | |||
| accessModes: | |||
| - ReadWriteMany | |||
| - ReadWriteOnce | |||
There was a problem hiding this comment.
each glance pod is going to have stable access to is own pvc
glance-0 -> pvc-0
glance-1 -> pvc-1
glance-2 -> pvc-2
fmount
commented
Nov 2, 2023
| @@ -284,15 +283,6 @@ func (r *GlanceReconciler) reconcileInit( | |||
| ) (ctrl.Result, error) { | |||
| r.Log.Info(fmt.Sprintf("Reconciling Service '%s' init", instance.Name)) | |||
|
|
|||
| // Define the PVCs objects required by Glance | |||
| ctrlResult, err := r.ensurePVC(ctx, helper, instance, serviceLabels) | |||
There was a problem hiding this comment.
moving to statefulset in the first place allow us to remove the PV creation logic from the glance-controller
fmount
commented
Nov 2, 2023
| @@ -699,6 +687,10 @@ func (r *GlanceReconciler) apiDeploymentCreateOrUpdate(ctx context.Context, inst | |||
| apiSpec.GlanceAPITemplate.NodeSelector = instance.Spec.NodeSelector | |||
| } | |||
|
|
|||
| // Inherit the values required for PVC creation from the top-level CR | |||
| apiSpec.GlanceAPITemplate.StorageRequest = instance.Spec.StorageRequest | |||
There was a problem hiding this comment.
All the instances needs to be tied to the same StorageClass and the same StorageRequest, hence this propagates the two fields to the statefulset that is supposed to create them via VolumeClaimTemplates
fmount
commented
Nov 2, 2023
Signed-off-by: Francesco Pantano <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the way the glance statefulset uses PVCs:
ensurePVCis not required anymore and the logic has been moved away from controller to thestatefulsetcreation functionstorageClassandstorageRequestare now fields of theGlanceAPITemplategetVolumesdon't requirepvc(s)anymoreDBSynconly mounts what it needs (Do not require DbSync to mount all the Glance volumes #351)GlanceAPIPvcis moved fromRWXtoRWO