Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing DPDK lcore list config #876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jaganathancse
Copy link
Contributor

This edpm_ovs_dpdk_lcore_list config is not
required now to enable ovs dpdk in EDPM
nodes.

@openshift-ci openshift-ci bot requested review from lewisdenny and viroel February 7, 2025 16:16
@rjarry
Copy link
Contributor

rjarry commented Feb 7, 2025

It is not only "not needed" it is "strongly discouraged and should never be used" :)

Copy link
Contributor

@rjarry rjarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed a spot left here:

edpm_ovs_dpdk_lcore_list: "0,12"

This edpm_ovs_dpdk_lcore_list config is not
required now to enable ovs dpdk in EDPM
nodes.
@Jaganathancse Jaganathancse force-pushed the dpdk_lcore_config_removal branch from 6f31f43 to b13d5b0 Compare February 7, 2025 16:28
@Jaganathancse
Copy link
Contributor Author

It looks like you missed a spot left here:

edpm_ovs_dpdk_lcore_list: "0,12"

yes Robin, Removed it. thanks.

@Jaganathancse Jaganathancse requested review from rjarry and abays February 7, 2025 16:30
@openshift-ci openshift-ci bot added the lgtm label Feb 7, 2025
Copy link
Contributor

openshift-ci bot commented Feb 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jaganathancse, rjarry
Once this PR has been reviewed and has the lgtm label, please assign frenzyfriday for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants