Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[repo_setup] Download rhos-release using kerberos #2632

Merged
merged 1 commit into from
Jan 13, 2025
Merged

[repo_setup] Download rhos-release using kerberos #2632

merged 1 commit into from
Jan 13, 2025
+228 −1

Conversation

pablintino
Copy link
Collaborator

@pablintino pablintino commented Jan 7, 2025 •
edited
Loading

If the RPM name points to a URL we now use a custom plugin to fetch the content.
If the endpoint challenges the plugins with SPNEGO authentication and a kerberos ticket is present the plugin will authenticate itself using the ticket.

@pablintino pablintino requested a review from lewisdenny as a code owner January 7, 2025 16:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@github-actions github-actions bot marked this pull request as draft January 7, 2025 16:45
@pablintino pablintino marked this pull request as ready for review January 7, 2025 16:45
@pablintino pablintino force-pushed the enable-kerberos-auth-for-repo-setup-downloads branch 5 times, most recently from cb583e8 to 0d09f4e Compare January 7, 2025 17:58
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/73bb248313af4a418c65a4fede86ccaf

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 13m 54s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 53s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 39s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 00m 41s
✔️ noop SUCCESS in 0s
❌ cifmw-pod-ansible-test FAILURE in 5m 21s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 24s
✔️ build-push-container-cifmw-client SUCCESS in 23m 03s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 10m 13s
✔️ cifmw-molecule-repo_setup SUCCESS in 5m 13s

@pablintino pablintino force-pushed the enable-kerberos-auth-for-repo-setup-downloads branch 11 times, most recently from 91ef3fa to aa3a61a Compare January 8, 2025 12:19
@pablintino pablintino changed the title [repo_setup] Download rhos-release using kerberos if needed [repo_setup] Download rhos-release using kerberos Jan 8, 2025
@pablintino pablintino force-pushed the enable-kerberos-auth-for-repo-setup-downloads branch from aa3a61a to 3dcca11 Compare January 8, 2025 12:23
@frenzyfriday
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 8, 2025
frenzyfriday
frenzyfriday approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@frenzyfriday frenzyfriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

evallesp
evallesp reviewed Jan 9, 2025
View reviewed changes
Copy link

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I have some questions and a suggestion of using a builtin module.
In any case, I like the custom module, and I don't have a problem of maintain it's usage instead my suggestion.

roles/repo_setup/tasks/rhos_release.yml Show resolved Hide resolved
roles/repo_setup/tasks/rhos_release.yml Show resolved Hide resolved
plugins/modules/url_request.py Show resolved Hide resolved
plugins/modules/url_request.py Show resolved Hide resolved
plugins/modules/url_request.py Outdated Show resolved Hide resolved
@pablintino pablintino force-pushed the enable-kerberos-auth-for-repo-setup-downloads branch from 3dcca11 to a4b70bb Compare January 9, 2025 12:16
@openshift-ci openshift-ci bot removed the lgtm label Jan 9, 2025
@pablintino
[repo_setup] Download rhos-release using kerberos
6c2a888 
If the RPM name points to a URL we now use a custom plugin to fetch the
content. If the endpoint challenges the plugins with SPNEGO
authentication and a kerberos ticket is present the plugin will
authenticate itself using the ticket.
@pablintino pablintino force-pushed the enable-kerberos-auth-for-repo-setup-downloads branch from a4b70bb to 6c2a888 Compare January 9, 2025 12:22
@frenzyfriday
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2025
@evallesp
Copy link

evallesp commented Jan 9, 2025

/lgtm

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/075ef7e5e148482a82ce346a9703c3af

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 50m 45s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 18m 44s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 21m 40s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 03m 37s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 37s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 28s
✔️ build-push-container-cifmw-client SUCCESS in 21m 34s
✔️ cifmw-molecule-build_openstack_packages SUCCESS in 10m 22s
✔️ cifmw-molecule-repo_setup SUCCESS in 4m 18s

@pablintino
Copy link
Collaborator Author

recheck

1 similar comment
@pablintino
Copy link
Collaborator Author

recheck

lewisdenny
lewisdenny approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice work guys

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7a168d2 into main Jan 13, 2025
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the enable-kerberos-auth-for-repo-setup-downloads branch January 13, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evallesp evallesp evallesp left review comments

@adrianfusco adrianfusco adrianfusco left review comments

@lewisdenny lewisdenny lewisdenny approved these changes

@frenzyfriday frenzyfriday frenzyfriday approved these changes

Assignees

@evallesp evallesp

@frenzyfriday frenzyfriday

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pablintino @frenzyfriday @evallesp @lewisdenny @adrianfusco