[OSASINFRA] Add the rhoso kubeconfig to the shiftstack client pod #2576

itzikb-redhat · 2024-11-28T11:01:17Z

Add the kube config of RHOSO to shiftstack client pod in order to access the clusterץ

Create a secret with the content of the kubeconfig.
Mount the secret as a volume in the shiftstackclient pod.
The kubeconfig can then be accessed from cifmw_shiftstack_shiftstackclient_incluster_kubeconfig_dir directory

openshift-ci · 2024-11-28T11:01:29Z

Hi @itzikb-redhat. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

github-actions · 2024-11-28T11:01:29Z

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

imatza-rh · 2024-11-28T12:06:42Z

roles/shiftstack/defaults/main.yml

@@ -31,6 +31,7 @@ cifmw_shiftstack_manifests_dir: "{{ cifmw_shiftstack_basedir }}/manifests"
 cifmw_shiftstack_project_name: "shiftstack"
 cifmw_shiftstack_qa_gerrithub_change: ""
 cifmw_shiftstack_qa_repo: "https://review.gerrithub.io/shiftstack/shiftstack-qa"
+cifmw_shiftstack_rhoso_kubeconfig : "{{ cifmw_shiftstack_shiftstackclient_installation_dir }}/rhoso_kubeconfig"


Please set the order so the cifmw_shiftstack_shiftstackclient_installation_dir is defined before use.

I think that from functionality perspective it doesn't matter and I want to have the variables in alphabetical order, wdyt?

softwarefactory-project-zuul · 2024-11-28T13:57:10Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ac2b82550ca74cf3a011b2139d4e57e1

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 53m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 50s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 03s
❌ cifmw-pod-pre-commit FAILURE in 7m 14s
✔️ build-push-container-cifmw-client SUCCESS in 37m 51s
✔️ cifmw-molecule-shiftstack SUCCESS in 12m 31s

itzikb-redhat · 2024-12-09T07:08:45Z

[cloud-admin@shiftstackclient-shiftstack ~]$ export KUBECONFIG=./artifacts/installation/rhoso_kubeconfig
[cloud-admin@shiftstackclient-shiftstack ~]$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0    True        False         21h     Cluster version is 4.16.0

eurijon

Hey Itzik, can you please add the PR description? I added a couple of minor comments too

roles/shiftstack/tasks/deploy_shiftstackclient_pod.yml

roles/shiftstack/tasks/main.yml

roles/shiftstack/tasks/post_deploy_shiftstackclient_pod.yml

softwarefactory-project-zuul · 2024-12-10T16:39:23Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4d22cb46c67e408b8949557e88ecc5c7

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 18m 19s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 32s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 58m 54s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 52s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 15s
✔️ build-push-container-cifmw-client SUCCESS in 22m 53s
❌ cifmw-molecule-shiftstack FAILURE in 14m 37s

itzikb-redhat · 2024-12-11T08:00:24Z

[zuul@controller-0 ~]$ oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0    True        False         6h48m   Cluster version is 4.16.0
[zuul@controller-0 ~]$ oc  -n openstack exec -it shiftstackclient-shiftstack /bin/bash
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl exec [POD] -- [COMMAND] instead.
[cloud-admin@shiftstackclient-shiftstack ~]$ export KUBECONFIG=./artifacts/installation/rhoso_kubeconfig
[cloud-admin@shiftstackclient-shiftstack ~]$ ./oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0    True        False         6h48m   Cluster version is 4.16.0

The job failed on a timeout downloading the client and installer but the kubeconfig is there

eurijon · 2024-12-11T10:57:43Z

/lgtm
/assign @rlobillo

rlobillo · 2024-12-11T11:31:14Z

I think you can acomplish this by playing the shiftstackclient manifest instead of manually copying

rlobillo · 2024-12-11T12:45:57Z

I think you can acomplish this by playing the shiftstackclient manifest instead of manually copying

.spec.automountServiceAccountToken may help for this

rlobillo · 2024-12-16T08:47:30Z

roles/shiftstack/defaults/main.yml

@@ -35,3 +37,4 @@ cifmw_shiftstack_run_playbook: "ocp_testing.yaml"
 cifmw_shiftstack_sc: "local-storage"
 cifmw_shiftstack_shiftstackclient_artifacts_dir: "/home/cloud-admin/artifacts"
 cifmw_shiftstack_shiftstackclient_installation_dir: "{{ cifmw_shiftstack_shiftstackclient_artifacts_dir }}/installation"
+cifmw_shiftstack_shiftstackclient_incluster_kubeconfig_dir: "/home/cloud-admin/kubeconfig"


Don't you think this filename could not be descriptive enough?

eurijon

Hey Itzik, can you please adapt the PR title (it's not being copied now but mounted) and add a descriptive PR description?

roles/shiftstack/README.md

roles/shiftstack/templates/shiftstackclient_pod.yml.j2

itzikb-redhat · 2024-12-16T10:48:38Z

Hey Itzik, can you please adapt the PR title (it's not being copied now but mounted) and add a descriptive PR description?

I updated - is it ok ?

eurijon · 2024-12-16T11:08:55Z

Hey Itzik, can you please adapt the PR title (it's not being copied now but mounted) and add a descriptive PR description?

I updated - is it ok ?

I would add in the PR description how the kubeconfig is mounted in the pod as a secret type volume. Thx!

softwarefactory-project-zuul · 2024-12-16T14:55:30Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf209bc54b3e4cdbaeb3a7806df1f2e5

❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007705192 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 10s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 22s
✔️ build-push-container-cifmw-client SUCCESS in 36m 00s
✔️ cifmw-molecule-shiftstack SUCCESS in 15m 05s

itzikb-redhat · 2024-12-17T11:25:47Z

recheck

Create a secret from the file and add it as a volume to the pod

eurijon · 2024-12-17T13:12:03Z

/lgtm

pablintino · 2024-12-19T11:20:14Z

/approve

openshift-ci · 2024-12-19T11:20:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pablintino]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eurijon · 2025-01-17T10:43:21Z

/cherry-pick 18.0-fr1

openshift-cherrypick-robot · 2025-01-17T10:43:58Z

@eurijon: #2576 failed to apply on top of branch "18.0-fr1":

Applying: Add RHOSO kubeconfigfile to shiftstackclient pod
Using index info to reconstruct a base tree...
M	roles/shiftstack/README.md
M	roles/shiftstack/tasks/cleanup.yml
M	roles/shiftstack/tasks/deploy_shiftstackclient_pod.yml
Falling back to patching base and 3-way merge...
Auto-merging roles/shiftstack/tasks/deploy_shiftstackclient_pod.yml
Auto-merging roles/shiftstack/tasks/cleanup.yml
Auto-merging roles/shiftstack/README.md
CONFLICT (content): Merge conflict in roles/shiftstack/README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Add RHOSO kubeconfigfile to shiftstackclient pod

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

eurijon · 2025-01-17T12:09:15Z

Manual cherry-pick on #2666

openshift-ci bot added the needs-ok-to-test label Nov 28, 2024

github-actions bot marked this pull request as draft November 28, 2024 11:01

openshift-ci bot added the do-not-merge/work-in-progress label Nov 28, 2024

imatza-rh reviewed Nov 28, 2024

View reviewed changes

itzikb-redhat force-pushed the shiftstack-rhoso-kubeconfig branch 3 times, most recently from 459a04c to 6e2be3a Compare December 5, 2024 05:55

itzikb-redhat marked this pull request as ready for review December 9, 2024 07:09

openshift-ci bot removed the do-not-merge/work-in-progress label Dec 9, 2024

github-actions bot added the Ready For Review label Dec 9, 2024

eurijon reviewed Dec 9, 2024

View reviewed changes

roles/shiftstack/tasks/deploy_shiftstackclient_pod.yml Outdated Show resolved Hide resolved

roles/shiftstack/tasks/deploy_shiftstackclient_pod.yml Outdated Show resolved Hide resolved

itzikb-redhat force-pushed the shiftstack-rhoso-kubeconfig branch from 6e2be3a to 36c5503 Compare December 10, 2024 14:19

github-actions bot removed the Ready For Review label Dec 10, 2024

eurijon reviewed Dec 10, 2024

View reviewed changes

roles/shiftstack/tasks/main.yml Outdated Show resolved Hide resolved

roles/shiftstack/tasks/post_deploy_shiftstackclient_pod.yml Outdated Show resolved Hide resolved

itzikb-redhat force-pushed the shiftstack-rhoso-kubeconfig branch from 36c5503 to c004f84 Compare December 10, 2024 17:54

github-actions bot added the Ready For Review label Dec 10, 2024

openshift-ci bot assigned rlobillo and eurijon Dec 11, 2024

openshift-ci bot added the lgtm label Dec 11, 2024

github-actions bot removed the Ready For Review label Dec 11, 2024

github-actions bot added the Ready For Review label Dec 11, 2024

rlobillo reviewed Dec 16, 2024

View reviewed changes

itzikb-redhat force-pushed the shiftstack-rhoso-kubeconfig branch from dfc0238 to e59bde6 Compare December 16, 2024 09:49

github-actions bot removed the Ready For Review label Dec 16, 2024

eurijon reviewed Dec 16, 2024

View reviewed changes

roles/shiftstack/README.md Outdated Show resolved Hide resolved

roles/shiftstack/templates/shiftstackclient_pod.yml.j2 Outdated Show resolved Hide resolved

itzikb-redhat force-pushed the shiftstack-rhoso-kubeconfig branch 3 times, most recently from 4d133df to 5c3fd12 Compare December 16, 2024 10:43

itzikb-redhat changed the title ~~[OSASINFRA] Copy rhoso kubeconfig to the shiftstack client pod~~ [OSASINFRA] Add the rhoso kubeconfig to the shiftstack client pod Dec 16, 2024

github-actions bot added the Ready For Review label Dec 16, 2024

itzikb-redhat force-pushed the shiftstack-rhoso-kubeconfig branch from 5c3fd12 to 613a050 Compare December 16, 2024 14:18

github-actions bot removed the Ready For Review label Dec 16, 2024

Add RHOSO kubeconfigfile to shiftstackclient pod

8498c98

Create a secret from the file and add it as a volume to the pod

itzikb-redhat force-pushed the shiftstack-rhoso-kubeconfig branch from 613a050 to 8498c98 Compare December 17, 2024 13:10

openshift-ci bot added the lgtm label Dec 17, 2024

github-actions bot added the Ready For Review label Dec 17, 2024

openshift-ci bot added the approved label Dec 19, 2024

github-actions bot added Ready For Review and removed Ready For Review labels Dec 19, 2024

openshift-merge-bot bot merged commit 63f8e1b into openstack-k8s-operators:main Dec 19, 2024
5 checks passed

eurijon mentioned this pull request Jan 17, 2025

[18.0-fr1] Add RHOSO kubeconfigfile to shiftstackclient pod #2666

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OSASINFRA] Add the rhoso kubeconfig to the shiftstack client pod #2576

[OSASINFRA] Add the rhoso kubeconfig to the shiftstack client pod #2576

itzikb-redhat commented Nov 28, 2024 •

edited

Loading

openshift-ci bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

imatza-rh Nov 28, 2024

itzikb-redhat Nov 28, 2024

softwarefactory-project-zuul bot commented Nov 28, 2024

itzikb-redhat commented Dec 9, 2024 •

edited

Loading

eurijon left a comment

softwarefactory-project-zuul bot commented Dec 10, 2024

itzikb-redhat commented Dec 11, 2024

eurijon commented Dec 11, 2024

rlobillo commented Dec 11, 2024

rlobillo commented Dec 11, 2024

rlobillo Dec 16, 2024

itzikb-redhat Dec 16, 2024

eurijon left a comment

itzikb-redhat commented Dec 16, 2024

eurijon commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

itzikb-redhat commented Dec 17, 2024

eurijon commented Dec 17, 2024

pablintino commented Dec 19, 2024

openshift-ci bot commented Dec 19, 2024

eurijon commented Jan 17, 2025

openshift-cherrypick-robot commented Jan 17, 2025

eurijon commented Jan 17, 2025

[OSASINFRA] Add the rhoso kubeconfig to the shiftstack client pod #2576

[OSASINFRA] Add the rhoso kubeconfig to the shiftstack client pod #2576

Conversation

itzikb-redhat commented Nov 28, 2024 • edited Loading

openshift-ci bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

imatza-rh Nov 28, 2024

Choose a reason for hiding this comment

itzikb-redhat Nov 28, 2024

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Nov 28, 2024

itzikb-redhat commented Dec 9, 2024 • edited Loading

eurijon left a comment

Choose a reason for hiding this comment

softwarefactory-project-zuul bot commented Dec 10, 2024

itzikb-redhat commented Dec 11, 2024

eurijon commented Dec 11, 2024

rlobillo commented Dec 11, 2024

rlobillo commented Dec 11, 2024

rlobillo Dec 16, 2024

Choose a reason for hiding this comment

itzikb-redhat Dec 16, 2024

Choose a reason for hiding this comment

eurijon left a comment

Choose a reason for hiding this comment

itzikb-redhat commented Dec 16, 2024

eurijon commented Dec 16, 2024

softwarefactory-project-zuul bot commented Dec 16, 2024

itzikb-redhat commented Dec 17, 2024

eurijon commented Dec 17, 2024

pablintino commented Dec 19, 2024

openshift-ci bot commented Dec 19, 2024

eurijon commented Jan 17, 2025

openshift-cherrypick-robot commented Jan 17, 2025

eurijon commented Jan 17, 2025

itzikb-redhat commented Nov 28, 2024 •

edited

Loading

itzikb-redhat commented Dec 9, 2024 •

edited

Loading