[18.0.0-proposed] Change order of if-elif conditionals in set_openstack_containers template #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late To update both container tags and ansiblee RELATED_VARS of openstack-operator in the same set_openstack_containers role run both cifmw_set_openstack_containers_tag and cifmw_set_openstack_containers_overrides are defined. cifmw_set_openstack_containers_overrides if conditional must be checked later, because otherwise container_tags modifications are all skipped.
4 tasks
|
Thanks for the PR! ❤️ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lewisdenny The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ah, need to rebase to remove the checkbox check |
lewisdenny
merged commit cc0e93f
into
openstack-k8s-operators:18.0.0-proposed
4 of 7 checks passed
|
I just wanted to rebase the PR, not merge it :/ @raukadah could you please double check your happy for this one to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2187
/assign ciecierski
#recheck