Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reproducer] Call switches config if available #2175

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[reproducer] Call switches config if available #2175

merged 1 commit into from
Aug 7, 2024

Conversation

pablintino
Copy link
Collaborator

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running
  • Appropriate documentation exists and/or is up-to-date:
    • README in the role
    • Content of the docs/source is reflecting the changes

@github-actions github-actions bot marked this pull request as draft July 29, 2024 14:32
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@pablintino pablintino force-pushed the reproducer/call-switch-config-if-available branch 5 times, most recently from 642498e to 8305a3d Compare August 5, 2024 10:20
@pablintino pablintino marked this pull request as ready for review August 5, 2024 10:20
cjeanner
cjeanner reviewed Aug 5, 2024
View reviewed changes
reproducer.yml Outdated Show resolved Hide resolved
cjeanner
cjeanner reviewed Aug 5, 2024
View reviewed changes
reproducer.yml Outdated Show resolved Hide resolved
@pablintino pablintino force-pushed the reproducer/call-switch-config-if-available branch from 8305a3d to 8aa3494 Compare August 5, 2024 11:55
@pablintino pablintino force-pushed the reproducer/call-switch-config-if-available branch from 8aa3494 to 656dfb2 Compare August 5, 2024 15:49
@pablintino pablintino force-pushed the reproducer/call-switch-config-if-available branch from 656dfb2 to 2a9fef2 Compare August 6, 2024 08:01
@pablintino pablintino force-pushed the reproducer/call-switch-config-if-available branch from 2a9fef2 to c6e2431 Compare August 6, 2024 13:29
@pablintino pablintino force-pushed the reproducer/call-switch-config-if-available branch from c6e2431 to bdaa782 Compare August 6, 2024 13:40
@cjeanner
Copy link
Contributor

cjeanner commented Aug 6, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cjeanner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 6, 2024
rebtoor
rebtoor reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f55a96a into main Aug 7, 2024
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the reproducer/call-switch-config-if-available branch August 7, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjeanner cjeanner cjeanner left review comments

@rebtoor rebtoor rebtoor left review comments

@lewisdenny lewisdenny lewisdenny requested changes

Assignees

@rebtoor rebtoor

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablintino @cjeanner @rebtoor @lewisdenny