Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0-fr1] Add RHOSO kubeconfigfile to shiftstackclient pod #2666

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[18.0-fr1] Add RHOSO kubeconfigfile to shiftstackclient pod #2666

merged 1 commit into from
Jan 17, 2025
+48 −0

Conversation

eurijon
Copy link
Contributor

@eurijon eurijon commented Jan 17, 2025

Manual cherry-pick of #2576

@itzikb-redhat @eurijon
Add RHOSO kubeconfigfile to shiftstackclient pod
e5d846d 
Create a secret from the file and add it as a volume to the pod
@github-actions github-actions bot marked this pull request as draft January 17, 2025 12:08
@github-actions GitHub Actions
Copy link

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

@eurijon eurijon mentioned this pull request Jan 17, 2025
Merged
@eurijon eurijon marked this pull request as ready for review January 17, 2025 12:38
@eurijon
Copy link
Contributor Author

eurijon commented Jan 17, 2025

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

@eurijon: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pablintino
Copy link
Collaborator

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 17, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2c8f237 into openstack-k8s-operators:18.0-fr1 Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

@rlobillo rlobillo Awaiting requested review from rlobillo

Assignees

@pablintino pablintino

Labels
approved lgtm Ready For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurijon @pablintino @itzikb-redhat