Skip to content

Commit

Permalink
fix: fix major version tag fetch on pre-commit autoupdate
Browse files Browse the repository at this point in the history
- Created simple tags instead of annotated tags.
- Removed creation of minor version 2-digit tag.
  • Loading branch information
aj3sh committed Aug 12, 2024
1 parent 62e2ca4 commit 7c3b420
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
14 changes: 3 additions & 11 deletions .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,17 +27,9 @@ jobs:
git config user.name github-actions[bot]
git config user.email 41898282+github-actions[bot]@users.noreply.github.com
# removing previous tags
git tag -d v${{ steps.release.outputs.major }} || true
git tag -d v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true
git push origin :v${{ steps.release.outputs.major }} || true
git push origin :v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} || true
# creating new tags
git tag -a v${{ steps.release.outputs.major }} -m "Release v${{ steps.release.outputs.major }}"
git tag -a v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }} -m "Release v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }}"
git push origin v${{ steps.release.outputs.major }}
git push origin v${{ steps.release.outputs.major }}.${{ steps.release.outputs.minor }}
# create and push major version tag
git tag v${{ steps.release.outputs.major }}
git push origin v${{ steps.release.outputs.major }} -f
- name: Set up Python
uses: actions/setup-python@v5
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ For more details, please refer to the Conventional Commits specification at http
repos:
...
- repo: https://github.com/opensource-nepal/commitlint
rev: v1.0.0
rev: v1.2.0
hooks:
- id: commitlint
...
Expand Down

0 comments on commit 7c3b420

Please sign in to comment.