Add if check before calculating strings for log_debug #3963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue N/A
Noticed that debug logging takes a bit of CPU during assembly - even if the log is disabled. Turns out, it's because
log_debug
etc. aren't macros and, therefore, fully evaluate all arguments before forwarding to the logger. If the logger doesn't need to sink the resulting message, then the evaluation is wasted.Brief summary of changes
Debug
before computing quantities that may appear in a debug log messageTesting I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is