Initialize the texture string property previously unused. #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty trivial but necessary change to serialize texture string, needed now to test textures, will populate defaults in a later PR to modify xml comment. |
nickbianco
approved these changes
Nov 12, 2024
|
Thanks @nickbianco 👍 I guess a property that is never used can do without constructProperty since nobody tries to access it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #0
Brief summary of changes
SurfaceProperties (used to support visualization) had an optional property of texture that was never used, now I'm trying to use it but it appears the initialization of the property was missing. Adding it back.
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is