Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConstantCurvatureJoint to the bindings #3957

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Add ConstantCurvatureJoint to the bindings #3957

merged 2 commits into from
Nov 5, 2024

Conversation

nickbianco
Copy link
Member

@nickbianco nickbianco commented Nov 4, 2024 •
edited by aymanhab
Loading

Brief summary of changes

Self-explanatory: adds ConstantCurvatureJoint to the bindings.

Testing I've completed

Installed bindings locally in Python and instantiated a ConstantCurvatureJoint object successfully in a Python interpreter.

Looking for feedback on...

CHANGELOG.md (choose one)

  • updated.

This change is Reviewable

@nickbianco nickbianco marked this pull request as ready for review November 4, 2024 21:54
carmichaelong
carmichaelong approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@carmichaelong carmichaelong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with MATLAB bindings

@nickbianco nickbianco merged commit b8a032c into main Nov 5, 2024
12 checks passed
@nickbianco nickbianco deleted the constant_curvature_joint_bindings branch November 5, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmichaelong carmichaelong carmichaelong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickbianco @carmichaelong