-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CI script, add Mac arm64 and Ubuntu 22 builds #3946
Conversation
Add debugging line
@nickbianco For the record the LD_LIBRARY_PATH changes appear to have been lost before the python tests are run on ubuntu. If everything else passes though then feel free to merge and I will take it on. |
@aymanhab, gotcha. As discussed, we can come back around to this later to resolve the Python testing issues on Ubuntu. |
Installing the Mac Arm64 build into a local conda environment fails. @aymanhab, thoughts? Looks like the rpaths are not being set correctly?
|
@nickbianco Conda makes some assumptions about layout. When we build conda package, the conda build system modifies rpaths accordingly. I'd test installing in non conda environment using setup.py etc. but not sure conda would work out of the box. I'd also test java/matlab |
Yeah, it looks like |
Using a Python |
@aymanhab, this is ready for review. I didn't test the "Build GUI" workflow; let me know if you'd like that tested as well. |
Would be good to test just for completeness though it has no dependencies on ci scripts. |
@aymanhab, the GUI build job fails, I think because a personal access token needs to be added or updated. It's up to you if you consider that blocking here. |
Thanks for trying it out @nickbianco Definitely not blocking, will review accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nickbianco)
As discussed, the Ubuntu 22 failure is unrelated and the GUI build job will be resolved in a future PR. Thanks @aymanhab! |
Fixes issue #3944
Brief summary of changes
continuous_integration.yml
to include separate jobs for Mac x64 and Arm64 architectures.WrapEllipsoid
related to indexing a Mat44 that was causing the Ubuntu 22 job to fail.Testing I've completed
Ran the CI, and ran both the Windows and Mac performance analysis workflows.
Looking for feedback on...
CHANGELOG.md (choose one)
Performance analysis
Platform: Mac, GitHub Actions runner
This change is