Update setting PATH env for Linux build script #3932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexbeattie42 sorry for the delay! Giving this a test locally now. |
nickbianco
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
LGTM. Thanks for the nice change @alexbeattie42. I like that this also prevents the install path being repeatedly appended to ~/.bashrc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3928
Brief summary of changes
Check which shell the user is using and attempt to update path if the shell is bash.
Testing I've completed
Ran the build script multiple times to ensure that
.bashrcis updated if variable exists and created if it doesn't.Looking for feedback on...
grep, andsedavailable?CHANGELOG.md (choose one)
This change is