Set flags for Moco dependencies on Linux and MacOS build scripts #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will mark as completed as they finish:
@nickbianco Everything seems to work properly on a clean VM with Ubuntu 22.04, however, I do not have a Mac machine to test right now. |
|
I tested the script on my Mac machine and these changes worked, so I think we're okay to merge. |
|
The Windows failure seems unrelated (spdlog issue). |
|
I agree, we can merge. Also the script passed CI for Mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #3839
Brief summary of changes
Sets the CMake variables
OPENSIM_WITH_CASADIandOPENSIM_WITH_TROPTERin the opensim-core builds for both the Linux and MacOS build scripts.Testing I've completed
Ran both build scripts locally.
Looking for feedback on...
CHANGELOG.md (choose one)
This change is